Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License detections explorer indicates 2 detections but displays just 1 #562

Closed
johnmhoran opened this issue Apr 21, 2023 · 2 comments · Fixed by #569
Closed

License detections explorer indicates 2 detections but displays just 1 #562

johnmhoran opened this issue Apr 21, 2023 · 2 comments · Fixed by #569
Labels

Comments

@johnmhoran
Copy link
Member

Using SCWB 4.0.0rc2 on WSL2 Ubuntu-20.04 on Windows 10, the 2nd of 2 license detection entries on the left indicates detections in 2 files but only 1 is displayed. A screenshot:

image

and what I think is the relevant excerpt from the JSON scan file:

  "license_detections": [
    {
      "identifier": "apache_2_0-8352cbe6-d199-3a43-cdc8-b14a837e2ce6",
      "license_expression": "apache-2.0",
      "detection_count": 1,
      "detection_log": []
    },
    {
      "identifier": "apache_2_0-c4e30bcd-ccfd-bbc3-d2f1-196ab911e47d",
      "license_expression": "apache-2.0",
      "detection_count": 2,
      "detection_log": []
    }
  ],
@AyanSinhaMahapatra
Copy link
Member

The issue is that this is a package license detection where we add this from the file license detection and so these have the same license detection identifier.

We should

  • show two entries in the file_region table, one for the resource.license_detections and another for resource.package_data.license_detections
  • add another column (at first) in the file_region table called from_package and put ✔️ or ❌ accordingly for package/file detections

See the scancode result JSON attached (remove the .txt extension):
kubernetes-model-common-5.12.2.jar-v32rc4results.json.txt

@OmkarPh
Copy link
Collaborator

OmkarPh commented May 14, 2023

we can close this, as it's fixed & available in https://github.com/nexB/scancode-workbench/releases/tag/v4.0.0rc3

@OmkarPh OmkarPh closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants