Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest scancode toolkit #525

Closed
OmkarPh opened this issue May 18, 2022 · 8 comments
Closed

Support latest scancode toolkit #525

OmkarPh opened this issue May 18, 2022 · 8 comments
Labels
version4 Issue for v4

Comments

@OmkarPh
Copy link
Collaborator

OmkarPh commented May 18, 2022

Description

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Aug 30, 2022

Update - WIP in branch v4.0-react-typescript

@martin-langhoff
Copy link

martin-langhoff commented Dec 1, 2022

In my testing, latest release of ScanCode Workbench v3.1.1 works well with output from ScanCode Toolkit v30.1.0, but not with output from v31.x.y series.

When used with output from v31.x.y series, it just does not "see" or report any licenses or copyrights. Visualization only tracks directories/files, but no properties 'discovered' for them. The data is in the JSON file, but is not parsed by Workbench.

@pombredanne
Copy link
Member

@martin-langhoff This is correct, we have an updated branch that is pending last mile review before merging. Can you give a shot to #532 (only if you feel comfy with building from sources)

@martin-langhoff
Copy link

@pombredanne thanks for the update. I am more than happy to build from source but current master is pretty broken for me when building on Mac OS. node-gyp spews all over. I'll try on the PR branch you are suggesting and report on the PR itself.

@martin-langhoff
Copy link

Testing your PR

  • branch builds on my Mac OS 12.6.1 with Node from Brew (whereas develop is broken on node-gyp)
  • tested with an input report.json built with latest 'develop' commit in scancode-toolkit, the test run was over the git source code repo
  • Import worked well
  • In dashboard, Copyright Holders looks a bit odd (screencap below)
  • License info dashboard had no data, this is incorrect (JSON file has license data)

image

@martin-langhoff
Copy link

(posted same message on #532 )

@pombredanne
Copy link
Member

@martin-langhoff Thank you ++ for testing.
The issue is that we are in the process to update the data format for ScanCode licenses in the develop branch.
@AyanSinhaMahapatra ping

@mjherzog mjherzog added the version4 Issue for v4 label Mar 28, 2023
@AyanSinhaMahapatra
Copy link
Member

This is now completed with https://github.com/nexB/scancode-workbench/releases/tag/v4.0.0rc2 supporting the latest scancode-toolkit v32.x output format, code is at https://github.com/nexB/scancode-workbench/tree/v4.0-react-typescript

@martin-langhoff please do test this out 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version4 Issue for v4
Projects
None yet
Development

No branches or pull requests

5 participants