Skip to content

Commit

Permalink
Refine false positive and license clue rules
Browse files Browse the repository at this point in the history
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
  • Loading branch information
AyanSinhaMahapatra committed Sep 16, 2024
1 parent d8be90e commit d1b76a6
Show file tree
Hide file tree
Showing 16 changed files with 21 additions and 49 deletions.
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/false-positive_771.RULE
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ is_false_positive: yes
notes: seen in kernel /Documentation/process/license-rules.rst
---

The SPDX license identifier in kernel files shall be added at the first
The SPDX license identifier in kernel files
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/false-positive_772.RULE
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ is_false_positive: yes
notes: seen in kernel /Documentation/process/license-rules.rst
---

The SPDX license identifier is added in form of a comment.
The SPDX license identifier is added
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/false-positive_773.RULE
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ is_false_positive: yes
notes: seen in kernel /Documentation/process/license-rules.rst
---

(SPDX-License-Identifier) nor in any way relevant for expressing or
(SPDX-License-Identifier) nor
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/false-positive_774.RULE
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ is_false_positive: yes
notes: seen at drivers/block/floppy.c
---

* modeled after the freeware MS-DOS program fdformat/88 V1.8 by
* modeled after the freeware MS-DOS program
4 changes: 2 additions & 2 deletions src/licensedcode/data/rules/false-positive_776.RULE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
is_false_positive: yes
notes: seen in kernel /Documentation/process/license-rules.rst
notes: seen in kernel menuconfig
---

SPDX-License-Identifier: <SPDX License Expression>
_GNU_SOURCE
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/false-positive_781.RULE
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ is_false_positive: yes
notes: found in linux/drivers/gpu/drm/amd/include/asic_reg/nbio/
---

#define PCIE_RX_AD__RX_RC_UR_SSPL_MSG
UR_SSPL_MSG
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/false-positive_782.RULE
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ is_false_positive: yes
notes: found in linux/drivers/pinctrl/samsung/pinctrl-exynos-arm.c
---

EXYNOS_PIN_BANK_EINTG("gpl2")
EINTG("gpl2")
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/false-positive_783.RULE
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ is_false_positive: yes
notes: found in linux/drivers/pinctrl/samsung/pinctrl-exynos-arm.c
---

EXYNOS_PIN_BANK_EINTG("gpl1")
EINTG("gpl1")
6 changes: 0 additions & 6 deletions src/licensedcode/data/rules/false-positive_784.RULE

This file was deleted.

7 changes: 0 additions & 7 deletions src/licensedcode/data/rules/false-positive_786.RULE

This file was deleted.

6 changes: 0 additions & 6 deletions src/licensedcode/data/rules/false-positive_787.RULE

This file was deleted.

6 changes: 0 additions & 6 deletions src/licensedcode/data/rules/false-positive_788.RULE

This file was deleted.

12 changes: 0 additions & 12 deletions src/licensedcode/data/rules/gpl-2.0_1436.RULE

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ is_license_notice: yes
minimum_coverage: 90
---

The license described in the COPYING file applies to the kernel source
The license described in the {{COPYING file applies to the kernel source}}
as a whole, though individual source files can have a different license
which is required to be compatible with the GPL-2.0::

Expand Down
9 changes: 9 additions & 0 deletions src/licensedcode/data/rules/license-clue_gpl-2.0_1.RULE
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
license_expression: gpl-2.0
is_license_clue: yes
relevance: 80
minimum_coverage: 90
notes: found in linux/net/core/filter.c
---

EXPORT_PER_CPU_SYMBOL_GPL
4 changes: 2 additions & 2 deletions tests/licensedcode/data/datadriven/external/spdx/uboot.c.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ license_expressions:
- gpl-2.0-plus
- gpl-2.0-plus OR bsd-simplified
- gpl-2.0-plus OR bsd-simplified
- gpl-2.0-plus OR bsd-new
- gpl-2.0-plus OR bsd-new
- gpl-2.0-plus AND bsd-new
- gpl-2.0-plus AND bsd-new
- gpl-2.0 OR ibm-pibs
- isc
- lgpl-2.0-plus
Expand Down

0 comments on commit d1b76a6

Please sign in to comment.