Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calc isSidebarFitsViewport #137

Open
drebot92 opened this issue Sep 21, 2022 · 0 comments
Open

Calc isSidebarFitsViewport #137

drebot92 opened this issue Sep 21, 2022 · 0 comments

Comments

@drebot92
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/sticky-sidebar/dist/sticky-sidebar.js b/node_modules/sticky-sidebar/dist/sticky-sidebar.js
index 9a7cad4..e0707ec 100644
--- a/node_modules/sticky-sidebar/dist/sticky-sidebar.js
+++ b/node_modules/sticky-sidebar/dist/sticky-sidebar.js
@@ -308,7 +308,7 @@ var StickySidebar = function () {
     }, {
       key: 'isSidebarFitsViewport',
       value: function isSidebarFitsViewport() {
-        return this.dimensions.sidebarHeight < this.dimensions.viewportHeight;
+        return this.dimensions.sidebarHeight < this.dimensions.viewportHeight - this.dimensions.topSpacing - this.dimensions.bottomSpacing;
       }
 
       /**

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant