Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4687][Protocol-2] Fix duplicate outgoing ATTACH msg #416

Merged
merged 8 commits into from
Jul 4, 2024
Merged

[ECO-4687][Protocol-2] Fix duplicate outgoing ATTACH msg #416

merged 8 commits into from
Jul 4, 2024

Commits on Jun 24, 2024

  1. Refactored logic for sending ATTACH message 

    1. Send attach only when connection state is CONNECTED
2. Not queue attach message, instead send is immediately on connected
3. Removed use of emitter pattern while clearing attach/detach timers
    @sacOO7
    sacOO7 committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a3d9746 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. replaced next unless with assertive if condition for op retry on reco… 

    …nnection
    @sacOO7
    sacOO7 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1324a72 View commit details
    Browse the repository at this point in the history

  2. Refactored implementation for sending ATTACH and DETACH message 

    1. Moved sending ATTACH msg as a part of separate codebase
2. DETEACH msg will be re-attempted on reconnection if pending timer exist
3. notify_state_change made accessible to channel_state_machine
    @sacOO7
    sacOO7 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8b9b556 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Refactored channel attach, removed check for forced attach

    @sacOO7
    sacOO7 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2eba50f View commit details
    Browse the repository at this point in the history

  2. Refactored send_protocol_message method, removed unnecessary usage of… 

    … tap
    @sacOO7
    sacOO7 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7a973ae View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Synced protocol-2-presence changes

    @sacOO7
    sacOO7 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    d37be2f View commit details
    Browse the repository at this point in the history

  2. Updated channel_manager, 

    1. marked notify_state_change as accessible
2. annotated code with right spec ids
    @sacOO7
    sacOO7 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    07aadbd View commit details
    Browse the repository at this point in the history

  3. Added test to check for duplicate attach message sent or received

    @sacOO7
    sacOO7 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    47c55d7 View commit details
    Browse the repository at this point in the history