New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement batch operations feature #989

Closed

deanna-lad opened this issue May 23, 2022 · 0 comments · Fixed by #1410

Assignees

Labels

deanna-lad commented May 23, 2022 •

edited by sync-by-unito bot

Loading

Implement batch operations feature as described in the specification:
https://github.com/ably/docs/blob/main/content/client-lib-development-guide/features.textile#batch-operations

For reference please see: https://ably.com/docs/rest/batch

The original PR for spec creation: ably/docs#1421

Acceptance criteria: feature has been implemented and unit test has been written.

┆Issue is synchronized with this Jira Story by Unito

deanna-lad added the spec-alignment label

deanna-lad changed the title ~~Implement batch operations~~ Implement batch operations feature

QuintinWillison mentioned this issue

Add REST 'Batch Operations' features, including for publish (BO2a) and getPresence (BO2b) ably/features#81

Open

QuintinWillison added enhancement and removed spec-alignment labels

sync-by-unito bot assigned lawrence-forooghian

lawrence-forooghian mentioned this issue

Update publish methods to accept a Message-like type (including specification changes) #1398

Open

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

b302336

As described by spec at commit 85f1a39. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

198722b

As described by spec at commit 85f1a39. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch token revocation

261736c

As described by spec at commit 85f1a39. Resolves #989.

TODO docs

TODO update signatures after updating spec

lawrence-forooghian mentioned this issue

When client emits a 40171 error, the underlying auth failure is not exposed to user #1409

Open

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

e7ee8e5

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch token revocation

d0e2247

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

16ca81d

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian mentioned this issue

[SDK-1904] Implement batch operations #1410

Merged

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

00748ac

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

cc4c2e7

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

66707ba

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

1dce3d7

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

5ffe9f6

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

c277f55

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

5488e81

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

b388834

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

a2918a2

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

a488aff

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

830d997

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

7687cf9

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

a01bc4f

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

606795d

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

5470f46

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

2b242fb

As described by spec at commit c2155c5. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

152022e

As described by spec at commit c2155c5. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

26d4181

As described by spec at commit 595fdce. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

8d4b613

As described by spec at commit 595fdce. Part of #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

b7d8d72

As described by spec at commit 595fdce. Resolves #989.

TODO docs

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

7f233b8

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

f996cec

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

3c0e3d8

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Resolves #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

d782b25

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

e371d31

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

54646d0

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Resolves #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

6adbfc8

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Resolves #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

089e812

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Note that the tests which revoke tokens do so using a random clientId.
This is to prevent the revocations performed in one test from having an
effect on tokens issued in a subsequent test. (I observed this
happening, and Simon confirmed that it's possible for a token issued
very shortly after a revocation to be affected by that revocation.)

Resolves #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

be06b1f

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

35f8670

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

8ed4701

As described by spec at commit 0437830. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Note that the tests which revoke tokens do so using a random clientId.
This is to prevent the revocations performed in one test from having an
effect on tokens issued in a subsequent test. (I observed this
happening, and Simon confirmed that it's possible for a token issued
very shortly after a revocation to be affected by that revocation.)

Resolves #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

As described by spec at commit 18ef967. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

8dfaf25

As described by spec at commit 18ef967. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

01805ff

As described by spec at commit 18ef967. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Note that the tests which revoke tokens do so using a random clientId.
This is to prevent the revocations performed in one test from having an
effect on tokens issued in a subsequent test. (I observed this
happening, and Simon confirmed that it's possible for a token issued
very shortly after a revocation to be affected by that revocation.)

Resolves #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

bbbbbcb

As described by spec at commit 18ef967. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Note that the tests which revoke tokens do so using a random clientId.
This is to prevent the revocations performed in one test from having an
effect on tokens issued in a subsequent test. (I observed this
happening, and Simon confirmed that it's possible for a token issued
very shortly after a revocation to be affected by that revocation.)

Resolves #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch publish

21bd849

As described by spec at commit 18ef967. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST batch presence

f52b1ab

As described by spec at commit 18ef967. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Part of #989.

lawrence-forooghian added a commit that referenced this issue


          Implement REST token revocation

88bac53

As described by spec at commit 18ef967. Documentation based on
sdk-api-reference repo at commit 652ef2f.

Note that the tests which revoke tokens do so using a random clientId.
This is to prevent the revocations performed in one test from having an
effect on tokens issued in a subsequent test. (I observed this
happening, and Simon confirmed that it's possible for a token issued
very shortly after a revocation to be affected by that revocation.)

Resolves #989.

lawrence-forooghian closed this as completed in #1410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment