-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UWP release mode issue #106
Comments
@mattheworiordan can you ask the customer if they have a sample project that reproduces the issue. |
@marto83 have asked |
Just to confirm. I can reproduce the issue and am trying to find how to get it fixed. I'm open to suggestions if there are any :) |
Hi @marto83 - This issue might be caused by the msgpack.cli dependency. |
Thank you @DaTester. I had a look at the bug and it will not be fixed until the next RC. :( My options are kind of limited. I think for the time being I will fork the msgpack repo and create a new nuget package that fixes this until the official 0.9 rc comes out. |
Ok I understand @marto83, can give me estimated timescale on next RC? so we can plan for testing/release at that time. |
@DaTester to update you I'm stacked at the moment and won't have time to look into it for at least the next week. However, if you want to fork the MsgPack.Cli and release a version that removes the broken dependencies I'll be happy to release a new version pointing at your implementation. |
Thanks for the info @marto83 , It's ok we can wait as our developer is fixing critical issues in our app at present. |
Hi @DaTester. I've released a new version with the upgraded MsgPack.Cli dependency. Can you please try again with that version. |
Actually. I create a test project and still get the same error :(. It must be another package. Or maybe I need to create a separate nuget config for UWP. I'll look into it. |
Hi @marto83, Sounds like a bit a pain this issue. I'm pretty sure it's MsgPack.Cli that causes the failure because i tried including the package in a new Xamarin UWP project and it fails the same way in release mode. I really do hope you can find a work around for this issue. |
I updated to the latest beta of MsgPack and still get the error. Which version did you use? |
I tried it with the the latest stable version 0.8.1 and also tried the 0.9.0 beta 2 - both have same issue. |
@DaTester MsgPack is not ready. The only other way would be to find a way to switch off msgpack and release a json only version. Let me chat with @mattheworiordan. |
Hi @marto83 - tried the latest MsgPack release (0.9.1). I'm afraid issue still exists for UWP release version. I was really hoping issue would have been addressed in the latest package :-( |
Oh. That's disappointing :( |
Hi @marto83, We built the MsgPack using the latest source from NuGet and found it works fine in UWP release mode ( I have attached the MsgPack dll we built). But when we then include the ably.io package there is a conflict (two MsgPack files). Is it possible for you to create a ably.io package for us using the msgpack.dll? this will hopefully allow us to put our UWP app version on the windows store. |
@DaTester. That's great news. We can't publish a package with a local dependency unless you inline the other dll and last time I tried ILMerge didn't like the MsgPack dll. The other option is for you to pull this repo and change the dependency from nuget to your msgpack dll. This way you can build the library against it and you should be able to include ably + msgpack as local dependencies. |
ok thanks for the information. In our current development environment we use visual studio 2015 update 3. Do we need to update to VS 2017? |
@DaTester. Yes we are using 2017, so it's easier if you have it. You can run both 2015 and 2017 alongside each other. |
Thanks @marto83 , This workaround allowed us to to create package for UWP 👍 |
@DaTester I'm glad to hear that. 👍 |
Hi all |
This is no longer an issues as MsgPack is no longer bundled into the library. Once we have a stable release for MsgPack, then we will potentially reintroduce. |
From customer in ticket 1921:
I then asked:
Customer responded:
The text was updated successfully, but these errors were encountered: