Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinuities after detach #410

Open
AndyTWF opened this issue Nov 20, 2024 · 2 comments
Open

Discontinuities after detach #410

AndyTWF opened this issue Nov 20, 2024 · 2 comments

Comments

@AndyTWF
Copy link
Collaborator

AndyTWF commented Nov 20, 2024

At the moment, we emit discontinuity events after attaching channels after explicitly detaching them.

Should we forgo these events if the channel has been detached explicitly?

┆Issue is synchronized with this Jira Task by Unito

@sacOO7
Copy link

sacOO7 commented Nov 27, 2024

We emit reason:? ErrorInfo as a part of discontinuity.
Why not include the reason as explicitly detached while emitting discontinuity event, wdyt

@sacOO7
Copy link

sacOO7 commented Nov 27, 2024

At the same time, I would argue not to expose a lot of internal stuff, where customers need to add extra checks for discontinuity error type.
It would make sense only to emit discontinuity when it happens 👍 ( when there is no explicit user intervention)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants