From 178f8a0099f2a2ee21b84238b8cdc9d36bfbbced Mon Sep 17 00:00:00 2001 From: Alexander Lyon Date: Wed, 25 Sep 2024 17:10:19 +0200 Subject: [PATCH] add @taskr/esnext to pnpm root to resolve hoisting issues (#70349) ### What? Add `@taskr/esnext` to the root package.json to get around hoisting rules breaking `taskr`'s automatic discovery (and fix builds on some platforms where it is broken). ### Why? Some types of 'magically' imported packages (such as taskr automatically supporting es6 by just adding a package, or drizzle automatically finding a database driver) aren't hoisted on some platforms in the way the tool expects, breaking it. The symptom of this is taskr throwing a syntax error on some platforms, because we use ES6 syntax and it can't find the package it needs to support it. ### How? By adding it to the root package.json we ensure it is always hoisted in the way taskr expects. --- package.json | 1 + pnpm-lock.yaml | 19 ++++++++----------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/package.json b/package.json index bc650b6083af5..d680f5ad29c08 100644 --- a/package.json +++ b/package.json @@ -102,6 +102,7 @@ "@swc/core": "1.6.13", "@swc/helpers": "0.5.13", "@swc/types": "0.1.7", + "@taskr/esnext": "1.1.0", "@testing-library/jest-dom": "6.1.2", "@testing-library/react": "^15.0.5", "@types/busboy": "1.5.3", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 0cb37ab780bb2..f1ec1b544ebc5 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -134,6 +134,9 @@ importers: '@swc/types': specifier: 0.1.7 version: 0.1.7 + '@taskr/esnext': + specifier: 1.1.0 + version: 1.1.0 '@testing-library/jest-dom': specifier: 6.1.2 version: 6.1.2(@jest/globals@29.7.0)(@types/jest@29.5.5)(jest@29.7.0(@types/node@20.12.3)(babel-plugin-macros@3.1.0)) @@ -10796,10 +10799,6 @@ packages: resolution: {integrity: sha512-NbJtWIE2QEVbr9xQHXBY92fxX0Tu8EsS9NBwz7Qn3zoeuvcbP3LzBJw3EUJDpfb9IY8qnZvFSWIepeEFQga28w==} engines: {node: '>=4'} - mri@1.1.4: - resolution: {integrity: sha512-6y7IjGPm8AzlvoUrwAaw1tLnUBudaS3752vcd8JtrpGGQn+rXIe63LFVHm/YMwtqAuh+LJPCFdlLYPWM1nYn6w==} - engines: {node: '>=4'} - mri@1.2.0: resolution: {integrity: sha512-tzzskb3bG8LvYGFF/mDTpq3jpI6Q9wc3LEmBaghu+DdCssd1FakN7Bc0hVNmEyGq1bq3RgfkCb3cmQLpNPOroA==} engines: {node: '>=4'} @@ -14064,8 +14063,8 @@ packages: resolution: {integrity: sha512-ApGvZ6vVvTNdsmt676grvCkUCGwzG9IqXma5Z07xJgiC5L7akUMof5U8G2JTI9Rz/ovtVhJBlY6mNhEvtjzOIg==} engines: {node: '>=6'} - tinydate@1.2.0: - resolution: {integrity: sha512-3GwPk8VhDFnUZ2TrgkhXJs6hcMAIIw4x/xkz+ayK6dGoQmp2nUwKzBXK0WnMsqkh6vfUhpqQicQF3rbshfyJkg==} + tinydate@1.3.0: + resolution: {integrity: sha512-7cR8rLy2QhYHpsBDBVYnnWXm8uRTr38RoZakFSW7Bs7PzfMPNZthuMLkwqZv7MTu8lhQ91cOFYS5a7iFj2oR3w==} engines: {node: '>=4'} title-case@3.0.3: @@ -27088,8 +27087,6 @@ snapshots: mri@1.1.0: {} - mri@1.1.4: {} - mri@1.2.0: {} mrmime@2.0.0: {} @@ -30666,8 +30663,8 @@ snapshots: clor: 5.2.0 glob: 7.1.7 mk-dirs: 1.0.0 - mri: 1.1.4 - tinydate: 1.2.0 + mri: 1.2.0 + tinydate: 1.3.0 temp-dir@1.0.0: {} @@ -30798,7 +30795,7 @@ snapshots: tiny-lru@8.0.2: {} - tinydate@1.2.0: {} + tinydate@1.3.0: {} title-case@3.0.3: dependencies: