Skip to content

Commit dcad00b

Browse files
chrisbobbeabhi0504
authored andcommitted
nav: Stop dispatching all actions via Redux.
Instead, dispatch them via our recently added `NavigationService`. Add a few notes in `InitialNavigationDispatcher` about why we expect `NavigationService` to be ready in time. We chose to do the initial navigation here, rather than in a descendant of the `NavigationService`'s `ref`fed component for those reasons [1]. [1] zulip#4274 (comment)
1 parent b103b5a commit dcad00b

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/message/fetchActions.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
/* @flow strict-local */
22
import NavigationService from '../nav/NavigationService';
3-
import type { Narrow, Dispatch, GetState, GlobalState, Message, Action } from '../types';
4-
import type { ApiResponseServerSettings } from '../api/settings/getServerSettings';
3+
import type {
4+
Narrow,
5+
Dispatch,
6+
GetState,
7+
GlobalState,
8+
Message,
9+
Action,
10+
ApiResponseServerSettings,
11+
} from '../types';
512
import type { InitialData } from '../api/initialDataTypes';
613
import * as api from '../api';
714
import { resetToMainTabs } from '../actions';

0 commit comments

Comments
 (0)