Skip to content

refactor!: move encoding logic to sub-package #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

abemedia
Copy link
Owner

No description provided.

@abemedia abemedia force-pushed the refactor/encoding branch 3 times, most recently from f9799c1 to 757d564 Compare May 10, 2023 17:28
@abemedia abemedia force-pushed the refactor/encoding branch from 757d564 to 3f95838 Compare May 10, 2023 17:31
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (c8cd2de) 93.16% compared to head (3f95838) 93.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   93.16%   93.11%   -0.05%     
==========================================
  Files          19       19              
  Lines         775      770       -5     
==========================================
- Hits          722      717       -5     
  Misses         37       37              
  Partials       16       16              
Impacted Files Coverage Δ
api.go 100.00% <ø> (ø)
encoding/decode.go 100.00% <100.00%> (ø)
encoding/encode.go 100.00% <100.00%> (ø)
encoding/form/form.go 72.72% <100.00%> (ø)
encoding/json/json.go 100.00% <100.00%> (ø)
encoding/msgpack/msgpack.go 100.00% <100.00%> (ø)
encoding/text/decode.go 79.12% <100.00%> (ø)
encoding/text/encode.go 96.15% <100.00%> (ø)
encoding/xml/xml.go 100.00% <100.00%> (ø)
encoding/yaml/yaml.go 100.00% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Benchmark Result

Benchmark diff with base branch
goos: linux
goarch: amd64
pkg: github.com/abemedia/go-don
cpu: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
          │ bench-master.txt │           bench-new.txt            │
          │      sec/op      │   sec/op     vs base               │
Handler-2        562.1n ± 4%   520.4n ± 3%  -7.43% (p=0.000 n=10)

          │ bench-master.txt │         bench-new.txt          │
          │       B/op       │    B/op     vs base            │
Handler-2         72.00 ± 0%   72.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

          │ bench-master.txt │         bench-new.txt          │
          │    allocs/op     │ allocs/op   vs base            │
Handler-2         2.000 ± 0%   2.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@abemedia abemedia merged commit 8f50031 into master May 10, 2023
@abemedia abemedia deleted the refactor/encoding branch May 10, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant