Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event checks in test cases #824

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fix event checks in test cases #824

merged 2 commits into from
Mar 13, 2023

Conversation

miguelmtzinf
Copy link
Contributor

Closes #823

sakulstra and others added 2 commits March 7, 2023 18:51
@sakulstra @kyzia551
fix: Fix event emission checks in tests chai matchers
bf938d0 
* fix await emit in tests

* fix: await emit

---------

Co-authored-by: Andrei Kozlov <[email protected]>
@miguelmtzinf
fix: Format test files
cb8d339
@height
Copy link

height bot commented Mar 7, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@miguelmtzinf miguelmtzinf merged commit 29ff9b9 into master Mar 13, 2023
@miguelmtzinf miguelmtzinf deleted the fix/823-test-event-checks branch March 13, 2023 14:13
@github-actions github-actions bot mentioned this pull request Mar 13, 2023
Merged
This was referenced Jun 14, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Jul 13, 2024
Closed
@tobistudio tobistudio mentioned this pull request Jul 23, 2024
Closed
This was referenced Jul 31, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Aug 8, 2024
Closed
This was referenced Aug 16, 2024
Closed
Closed
This was referenced Aug 24, 2024
Closed
Closed
@tobistudio tobistudio mentioned this pull request Sep 1, 2024
Closed
This was referenced Sep 3, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Sep 10, 2024
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakulstra sakulstra sakulstra approved these changes

@foodaka foodaka foodaka approved these changes

@kartojal kartojal kartojal approved these changes

@The-3D The-3D Awaiting requested review from The-3D The-3D is a code owner

@Zer0dot Zer0dot Awaiting requested review from Zer0dot

@donosonaumczuk donosonaumczuk Awaiting requested review from donosonaumczuk

@eboadom eboadom Awaiting requested review from eboadom eboadom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checks of events emissions are not working well in tests due to wrong use of chai matchers
4 participants
@miguelmtzinf @sakulstra @foodaka @kartojal