Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition of full liquidation of collateral #753

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

miguelmtzinf
Copy link
Contributor

Closes #750

This is a fix of the PRs #740 and #747 that were incorrectly merged

@miguelmtzinf
Copy link
Contributor Author

It's not problematic to check the condition using the liquidationProtocolFeeAmount at that point, even if its re-adjusted afterwards. The re-calculation of the liquidationProtocolFeeAmount helps to ensure that there is 0 wei collateral if the asset is fully liquidated.

@miguelmtzinf miguelmtzinf merged commit 56bcf5d into feat/3.0.1 Dec 7, 2022
@miguelmtzinf miguelmtzinf deleted the fix/750-fix-full-collateral-liq-condition branch December 7, 2022 11:52
@miguelmtzinf miguelmtzinf mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants