Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CEI to fix reentrancy risk with reentrant tokens (eg ERC777) #704

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Fix: CEI to fix reentrancy risk with reentrant tokens (eg ERC777) #704

merged 4 commits into from
Nov 2, 2022

Conversation

The-3D
Copy link
Contributor

@The-3D The-3D commented Aug 8, 2022

No description provided.

@The-3D The-3D changed the base branch from master to feat/3.0.1 August 8, 2022 15:44
@codecov-commenter
Copy link

Codecov Report

Merging #704 (8e6cbc8) into feat/3.0.1 (a818243) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           feat/3.0.1     #704   +/-   ##
===========================================
  Coverage       99.95%   99.95%           
===========================================
  Files              45       45           
  Lines            2135     2137    +2     
  Branches          283      284    +1     
===========================================
+ Hits             2134     2136    +2     
  Misses              1        1
Impacted Files Coverage Δ
...acts/protocol/libraries/logic/LiquidationLogic.sol 100.00% <100.00%> (ø)
contracts/protocol/libraries/logic/SupplyLogic.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kyzia551
Copy link
Collaborator

Looks good for me

@miguelmtzinf miguelmtzinf merged commit 7fbdc6e into feat/3.0.1 Nov 2, 2022
@miguelmtzinf miguelmtzinf deleted the fix/reentrancy branch November 2, 2022 15:53
@eboadom eboadom mentioned this pull request Nov 16, 2022
Merged
@github-actions github-actions bot mentioned this pull request Dec 28, 2022
Merged
This was referenced Jun 14, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Jul 13, 2024
Closed
@tobistudio tobistudio mentioned this pull request Jul 23, 2024
Closed
This was referenced Jul 31, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Aug 8, 2024
Closed
@tobistudio tobistudio mentioned this pull request Aug 16, 2024
Closed
This was referenced Aug 22, 2024
Closed
Closed
This was referenced Aug 31, 2024
Closed
Closed
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Sep 10, 2024
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyzia551 kyzia551 kyzia551 left review comments

@miguelmtzinf miguelmtzinf miguelmtzinf approved these changes

@stevenvaleri stevenvaleri Awaiting requested review from stevenvaleri

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

@kartojal kartojal Awaiting requested review from kartojal

@Zer0dot Zer0dot Awaiting requested review from Zer0dot

@donosonaumczuk donosonaumczuk Awaiting requested review from donosonaumczuk donosonaumczuk is a code owner

@BenSparksCode BenSparksCode Awaiting requested review from BenSparksCode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@The-3D @codecov-commenter @kyzia551 @miguelmtzinf