From b76dcb731fc473aaef91141580ae4fd3d479deed Mon Sep 17 00:00:00 2001 From: miguelmtzinf Date: Fri, 7 Jan 2022 08:04:56 +0100 Subject: [PATCH] fix: Add visibility accessors to state variables of mocks --- .solhint.json | 5 +++++ contracts/mocks/flashloan/MockFlashLoanReceiver.sol | 6 +++--- contracts/mocks/flashloan/MockSimpleFlashLoanReceiver.sol | 6 +++--- contracts/mocks/helpers/MockPool.sol | 4 ++-- contracts/mocks/oracle/PriceOracle.sol | 5 +++-- 5 files changed, 16 insertions(+), 10 deletions(-) create mode 100644 .solhint.json diff --git a/.solhint.json b/.solhint.json new file mode 100644 index 000000000..bf546ef53 --- /dev/null +++ b/.solhint.json @@ -0,0 +1,5 @@ +{ + "rules": { + "max-line-length": "warn" + } + } \ No newline at end of file diff --git a/contracts/mocks/flashloan/MockFlashLoanReceiver.sol b/contracts/mocks/flashloan/MockFlashLoanReceiver.sol index 1e63ed3de..f0637061e 100644 --- a/contracts/mocks/flashloan/MockFlashLoanReceiver.sol +++ b/contracts/mocks/flashloan/MockFlashLoanReceiver.sol @@ -13,9 +13,9 @@ contract MockFlashLoanReceiver is FlashLoanReceiverBase { event ExecutedWithFail(address[] _assets, uint256[] _amounts, uint256[] _premiums); event ExecutedWithSuccess(address[] _assets, uint256[] _amounts, uint256[] _premiums); - bool _failExecution; - uint256 _amountToApprove; - bool _simulateEOA; + bool internal _failExecution; + uint256 internal _amountToApprove; + bool internal _simulateEOA; constructor(IPoolAddressesProvider provider) FlashLoanReceiverBase(provider) {} diff --git a/contracts/mocks/flashloan/MockSimpleFlashLoanReceiver.sol b/contracts/mocks/flashloan/MockSimpleFlashLoanReceiver.sol index efafdf4a0..ac2678a15 100644 --- a/contracts/mocks/flashloan/MockSimpleFlashLoanReceiver.sol +++ b/contracts/mocks/flashloan/MockSimpleFlashLoanReceiver.sol @@ -16,9 +16,9 @@ contract MockFlashLoanSimpleReceiver is FlashLoanSimpleReceiverBase { event ExecutedWithFail(address asset, uint256 amount, uint256 premium); event ExecutedWithSuccess(address asset, uint256 amount, uint256 premium); - bool _failExecution; - uint256 _amountToApprove; - bool _simulateEOA; + bool internal _failExecution; + uint256 internal _amountToApprove; + bool internal _simulateEOA; constructor(IPoolAddressesProvider provider) FlashLoanSimpleReceiverBase(provider) {} diff --git a/contracts/mocks/helpers/MockPool.sol b/contracts/mocks/helpers/MockPool.sol index 664fc2845..685782c5c 100644 --- a/contracts/mocks/helpers/MockPool.sol +++ b/contracts/mocks/helpers/MockPool.sol @@ -7,8 +7,8 @@ contract MockPool { // Reserved storage space to avoid layout collisions. uint256[100] private ______gap; - address _addressesProvider; - address[] _reserveList; + address internal _addressesProvider; + address[] internal _reserveList; function initialize(address provider) external { _addressesProvider = provider; diff --git a/contracts/mocks/oracle/PriceOracle.sol b/contracts/mocks/oracle/PriceOracle.sol index d45a462b9..90d2cd76b 100644 --- a/contracts/mocks/oracle/PriceOracle.sol +++ b/contracts/mocks/oracle/PriceOracle.sol @@ -4,8 +4,9 @@ pragma solidity 0.8.10; import {IPriceOracle} from '../../interfaces/IPriceOracle.sol'; contract PriceOracle is IPriceOracle { - mapping(address => uint256) prices; - uint256 ethPriceUsd; + mapping(address => uint256) internal prices; + + uint256 internal ethPriceUsd; event AssetPriceUpdated(address asset, uint256 price, uint256 timestamp); event EthPriceUpdated(uint256 price, uint256 timestamp);