Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jost font displays incorrectly on macOS #45

Open
iammattcoleman opened this issue Mar 14, 2022 · 2 comments
Open

Jost font displays incorrectly on macOS #45

iammattcoleman opened this issue Mar 14, 2022 · 2 comments

Comments

@iammattcoleman
Copy link
Contributor

The font included with this theme contains an uppercase "A" character that does not display correctly on all operating systems and browsers.

Here's how it looks on my system:
image

The issue is described in this ticket:
google/fonts#2602

Replacing @import "common/fonts"; with either of the following causes it to render correctly:

@import url('https://fonts.googleapis.com/css2?family=Jost:ital,wght@0,400;0,500;0,700;1,400;1,500;1,700&display=swap');
@import url("https://indestructibletype-fonthosting.github.io/jost.css");

(For the second URL, I also had to change the font name in _variables.scss to "Jost*".)

After making that change, the font displays correctly:
image

@iammattcoleman
Copy link
Contributor Author

I got the googleapis.com import directive from #8.

@iammattcoleman
Copy link
Contributor Author

iammattcoleman commented Mar 20, 2022

How did you obtain or generate the font files included with this theme?

To fix the issue but avoid leaking my visitors' IP addresses to either googleapis.com or github.io, I copied the CSS from indestructible-type and downloaded all the WOFF/WOFF2 files that the CSS references. The downloaded files are noticeably different from the ones you included in the theme:

  • The theme has 1/3 the number of font files:
    $ ls -1 themes/adidoks/static/fonts/vendor/jost/ | wc -l
          12
    $ ls -1 static/fonts/vendor/jost/ | wc -l
          36
    
  • The theme's font files have v4 in their names but the upstream repo, indestructible-type/Jost, is only on version 3.7.
  • The theme's font files are much smaller:
    $ du -hs themes/adidoks/static/fonts/vendor/jost/ static/fonts/vendor/jost/
    164K	themes/adidoks/static/fonts/vendor/jost/
    1.2M	static/fonts/vendor/jost/
    
    Is this due to Fonts include latin-only characters #8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant