Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Bootstrap setup #26

Open
ajyoon opened this issue Dec 5, 2021 · 1 comment
Open

Document Bootstrap setup #26

ajyoon opened this issue Dec 5, 2021 · 1 comment

Comments

@ajyoon
Copy link
Contributor

ajyoon commented Dec 5, 2021

Working on some page layouts with this theme, I was extremely confused why my column layouts weren't working as expected. After much debugging and searching I realized the theme sets $grid-columns: 16, instead of the default 12. It would be very helpful if settings like this were clearly documented on the website.

@ajyoon
Copy link
Contributor Author

ajyoon commented Dec 5, 2021

On a related note, while looking into this I discovered that this theme uses a beta branch of Bootstrap 5 (5.0.0-beta3), while the readme here had me thinking it was Bootstrap 4. It might be worth updating the dependency now that Bootstrap 5.0 is out, or perhaps pulling bootstrap in as a submodule instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant