From a8c9ef68f58bf9310b37069764208b5a0a2d5e8c Mon Sep 17 00:00:00 2001 From: Abhijay Jain Date: Mon, 3 Aug 2026 19:24:20 +0530 Subject: [PATCH 1/2] fix(acp): prefix child stderr log target so it passes the default goose=info filter --- crates/goose/src/acp/provider.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/crates/goose/src/acp/provider.rs b/crates/goose/src/acp/provider.rs index 26f0ce04f1b7..e64edc337e17 100644 --- a/crates/goose/src/acp/provider.rs +++ b/crates/goose/src/acp/provider.rs @@ -1,3 +1,4 @@ +use agent_client_protocol::schema::ProtocolVersion; use agent_client_protocol::schema::v1::{ Annotations as AcpAnnotations, ClientCapabilities, CloseSessionRequest, ContentBlock, ContentChunk, EnvVariable, HttpHeader, ImageContent, InitializeRequest, InitializeResponse, @@ -9,10 +10,9 @@ use agent_client_protocol::schema::v1::{ SetSessionModeRequest, SetSessionModeResponse, StopReason, TextContent, ToolCallContent, ToolCallStatus, ToolKind, }; -use agent_client_protocol::schema::ProtocolVersion; use agent_client_protocol::{Agent, Client, ConnectionTo}; -use agent_client_protocol_schema::v1::Usage as AcpUsage; use agent_client_protocol_schema::v1::AGENT_METHOD_NAMES; +use agent_client_protocol_schema::v1::Usage as AcpUsage; use anyhow::{Context, Result}; use async_stream::try_stream; use futures::future::BoxFuture; @@ -23,20 +23,20 @@ use std::future::Future; use std::path::PathBuf; use std::process::Stdio; use std::sync::{ - atomic::{AtomicBool, AtomicU64, Ordering}, Arc, Mutex, + atomic::{AtomicBool, AtomicU64, Ordering}, }; use std::thread::JoinHandle; use tokio::io::AsyncReadExt; use tokio::process::{Child, Command}; -use tokio::sync::{mpsc, oneshot, Mutex as TokioMutex}; +use tokio::sync::{Mutex as TokioMutex, mpsc, oneshot}; use tokio_util::compat::{TokioAsyncReadCompatExt as _, TokioAsyncWriteCompatExt as _}; -use crate::acp::{map_permission_response, PermissionDecision}; +use crate::acp::{PermissionDecision, map_permission_response}; use crate::config::{ExtensionConfig, GooseMode}; use crate::context_mgmt::format_message_for_compacting; -use crate::conversation::message::{Message, MessageContent, TOOL_META_EXTERNAL_DISPATCH_KEY}; use crate::conversation::Conversation; +use crate::conversation::message::{Message, MessageContent, TOOL_META_EXTERNAL_DISPATCH_KEY}; use crate::permission::permission_confirmation::PrincipalType; use crate::permission::{Permission, PermissionConfirmation}; use crate::providers::base::{MessageStream, PermissionRouting, Provider}; @@ -1009,7 +1009,7 @@ async fn forward_child_stderr(mut stderr: tokio::process::ChildStderr) { } } Err(e) => { - tracing::debug!(target: "acp::child::stderr", error = %e, "stderr read error"); + tracing::debug!(target: "goose::acp::child::stderr", error = %e, "stderr read error"); break; } } @@ -1022,7 +1022,7 @@ fn emit_stderr_line(line: &mut Vec) { return; } let trimmed = line.strip_suffix(b"\r").unwrap_or(line); - tracing::info!(target: "acp::child::stderr", "{}", String::from_utf8_lossy(trimmed)); + tracing::info!(target: "goose::acp::child::stderr", "{}", String::from_utf8_lossy(trimmed)); line.clear(); } From 469e65c7f6a8d440f66d80085337c7f2f46a6df8 Mon Sep 17 00:00:00 2001 From: Abhijay Jain Date: Mon, 3 Aug 2026 19:41:52 +0530 Subject: [PATCH 2/2] fix: revert rustfmt import reordering to match CI toolchain --- crates/goose/src/acp/provider.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/goose/src/acp/provider.rs b/crates/goose/src/acp/provider.rs index e64edc337e17..cbddeac5088b 100644 --- a/crates/goose/src/acp/provider.rs +++ b/crates/goose/src/acp/provider.rs @@ -1,4 +1,3 @@ -use agent_client_protocol::schema::ProtocolVersion; use agent_client_protocol::schema::v1::{ Annotations as AcpAnnotations, ClientCapabilities, CloseSessionRequest, ContentBlock, ContentChunk, EnvVariable, HttpHeader, ImageContent, InitializeRequest, InitializeResponse, @@ -10,9 +9,10 @@ use agent_client_protocol::schema::v1::{ SetSessionModeRequest, SetSessionModeResponse, StopReason, TextContent, ToolCallContent, ToolCallStatus, ToolKind, }; +use agent_client_protocol::schema::ProtocolVersion; use agent_client_protocol::{Agent, Client, ConnectionTo}; -use agent_client_protocol_schema::v1::AGENT_METHOD_NAMES; use agent_client_protocol_schema::v1::Usage as AcpUsage; +use agent_client_protocol_schema::v1::AGENT_METHOD_NAMES; use anyhow::{Context, Result}; use async_stream::try_stream; use futures::future::BoxFuture; @@ -23,20 +23,20 @@ use std::future::Future; use std::path::PathBuf; use std::process::Stdio; use std::sync::{ - Arc, Mutex, atomic::{AtomicBool, AtomicU64, Ordering}, + Arc, Mutex, }; use std::thread::JoinHandle; use tokio::io::AsyncReadExt; use tokio::process::{Child, Command}; -use tokio::sync::{Mutex as TokioMutex, mpsc, oneshot}; +use tokio::sync::{mpsc, oneshot, Mutex as TokioMutex}; use tokio_util::compat::{TokioAsyncReadCompatExt as _, TokioAsyncWriteCompatExt as _}; -use crate::acp::{PermissionDecision, map_permission_response}; +use crate::acp::{map_permission_response, PermissionDecision}; use crate::config::{ExtensionConfig, GooseMode}; use crate::context_mgmt::format_message_for_compacting; -use crate::conversation::Conversation; use crate::conversation::message::{Message, MessageContent, TOOL_META_EXTERNAL_DISPATCH_KEY}; +use crate::conversation::Conversation; use crate::permission::permission_confirmation::PrincipalType; use crate::permission::{Permission, PermissionConfirmation}; use crate::providers::base::{MessageStream, PermissionRouting, Provider};