Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-activate Notebook validation #64

Open
turnmanh opened this issue Mar 6, 2024 · 0 comments
Open

Re-activate Notebook validation #64

turnmanh opened this issue Mar 6, 2024 · 0 comments
Labels
enhancement New feature or request house-keeping Things that have to be done to ensure quality

Comments

@turnmanh
Copy link
Collaborator

turnmanh commented Mar 6, 2024

In order to push notebooks with a commented load stmt. - s.t. participants don't accidentally see the solution - the validation was deactivated in a589d85. However, it is a useful check to not hand out notebooks with solutions included. Therefore, it has to be re-activated with a nice workaround s.t. the %load magic command not executed by accident.

      - name: validate notebooks
        run: |
          for notebook in notebooks/*.ipynb; do
            if grep -q '# *%load ' "$notebook"; then
              echo "$notebook contains an executed load statement. 
          This is not allowed inside the docker image for participants, make sure you remove this
          in a future commit."
              exit 255
            fi
          done
@turnmanh turnmanh added enhancement New feature or request house-keeping Things that have to be done to ensure quality labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request house-keeping Things that have to be done to ensure quality
Projects
None yet
Development

No branches or pull requests

1 participant