WIP: Feature/refactor value #558
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py - rename source-file to git-split-temp
….py - resolve conflict and keep both files
….py - restore name of source-file
…tion.py - rename file to target-name
…tion.py - rename source-file to git-split-temp
…tion.py - resolve conflict and keep both files
…tion.py - restore name of source-file
…ile to target-name
…ource-file to git-split-temp
…conflict and keep both files
…name of source-file
…file to git-split-temp
…ct and keep both files
…e-file to git-split-temp
…lict and keep both files
… file to target-name
… source-file to git-split-temp
…e conflict and keep both files
…e name of source-file
… rename file to target-name
… rename source-file to git-split-temp
… resolve conflict and keep both files
… restore name of source-file
…name file to target-name
…name source-file to git-split-temp
…solve conflict and keep both files
Co-authored-by: Anes Benmerzoug <[email protected]>
Co-authored-by: Kristof Schröder <[email protected]>
Feature/refactor gt
This was referenced Jun 20, 2024
… - rename file to target-name
… - rename source-file to git-split-temp
… - resolve conflict and keep both files
… - restore name of source-file
| @@ -92,13 +92,13 @@ class DummyModel(SupervisedModel): | |||
| def __init__(self) -> None: | |||
| pass | |||
|
|
|||
| def fit(self, x: NDArray, y: NDArray) -> None: | |||
There was a problem hiding this comment.
Shouldn't this module moved to the new valuation package?
P.S. This comment is not about this specific line. I just found it easier to comment on it.
| ) | ||
| ensure_backend_has_generator_return() | ||
|
|
||
| self.utility.training_data = data |
There was a problem hiding this comment.
Suggested change
| self.utility.training_data = data | |
| self.utility.with_dataset(data) |
| """ | ||
| ... | ||
|
|
||
| def fit(self, data: Dataset): |
There was a problem hiding this comment.
Why not change the signature to this to allow using the dataset set on the utility, if there is one of course?
Suggested change
| def fit(self, data: Dataset): | |
| def fit(self, data: Dataset | None = None): |
4 tasks
Co-authored-by: Kristof Schröder <[email protected]>
| def __init__( | ||
| self, | ||
| model: ModelT, | ||
| scorer: Scorer, |
There was a problem hiding this comment.
The scorer is no longer the model's default scorer. Was it changed on purpose?
janosg
reviewed
Jul 9, 2024
| self, | ||
| utility: UtilityBase, | ||
| sampler: IndexSampler, | ||
| is_done: StoppingCriterion, |
There was a problem hiding this comment.
This comes out of a discussion with @schroedk: is_done sounds like a bool. We should discuss renaming this across all methods to something like stopping or stop_criterion
Co-authored-by: Kristof Schröder <[email protected]>
Refactor MSR Banzhaf valuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #XXX
closes #539
closes #187
Changes
Checklist
"tags": ["hide"]or"tags": ["hide-input"]