Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upstream] Tag names cannot contain spaces #282

Open
nicholasjng opened this issue Jun 28, 2024 · 1 comment
Open

[upstream] Tag names cannot contain spaces #282

nicholasjng opened this issue Jun 28, 2024 · 1 comment
Labels
bug Something isn't working triage Requires initial review (is duplicate, reproduce bug, severity or priority)

Comments

@nicholasjng
Copy link
Collaborator

What happened?

Creating tags as such:

with fs.transaction(repository.id) as tx:
    sha = tx.rev_parse("main")
    tag = tx.tag(sha, "v2 pipapo hello")

does not work because the lakeFS API rejects tag names containing spaces. It says

lakefs.exceptions.BadRequestException: code: 400, reason: Bad Request, body: {'message': 'argument tagID: tag id: invalid value: validation error'}

but with no mention as to what the validation mechanism (probably regex?) actually is. This would benefit from a bit of validation before sending the API request, to give the user a clearer idea of what actually went wrong.

IMO, it doesn't actually matter where that validation is happening, so it might as well be in lakeFS's Python wrapper project.

What did you expect to happen?

The tag being created just fine.

lakeFS-spec version

HEAD

lakeFS version

latest

@nicholasjng nicholasjng added bug Something isn't working triage Requires initial review (is duplicate, reproduce bug, severity or priority) labels Jun 28, 2024
@nicholasjng
Copy link
Collaborator Author

cc @oeladawyaai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Requires initial review (is duplicate, reproduce bug, severity or priority)
Projects
None yet
Development

No branches or pull requests

1 participant