-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh indicator overlays on list view #46
Comments
Thank you for pointing this out. The latest commit fdf49fd solves the above issue. @aagarwal1012 Please check as it shows an error on while passing the build. |
@AadumKhor, Travis shows a successful build but codecov shows that it degrades code coverage which we can deal later on. Your commit looks fine to proceed towards creating a Pull Request for the issue. |
@aagarwal1012 I have made the changes directly to the master branch. |
@AadumKhor, I will not suggest to directly push to master rather try to create a PR next time. |
@aagarwal1012 Ok. Will do in case of further issues. |
So I am guessing a new release needs to be created to be able to tests this? |
Yes, I will do the release by today. |
Great, look forward to trying the new version. Thanks. |
Closing this since the issue is resolved. |
interesting, maybe I have missed the release.... |
Any news on new version with this fix :) ? |
@dukaric1991 @limpep I have published a new version of this package, |
@aagarwal1012 I can confirm that it is working now. Thanks, much appreciated. |
@aagarwal1012 i can also confirm that it works as expected! thanks! |
I've upgrade from version 1.1.1 to 2.0.0 and now I'm encountering the same problem as mentioned in the original post here. |
Describe the bug
Hi, when you pull to refresh and the refresh indicator is overlayed on top of the list rather than pushing the list view down as shown in the screencasts on the readme.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The refresh indicator should push the list view down.
Screenshots
Flutter:
Dart:
• Dart version 2.7.2
Additional context
sdk: ">=2.7.0 <3.0.0"
liquid_pull_to_refresh: ^1.2.0
The text was updated successfully, but these errors were encountered: