Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation customization requests #33

Closed
1 of 3 tasks
SaadArdati opened this issue Sep 19, 2019 · 2 comments
Closed
1 of 3 tasks

Animation customization requests #33

SaadArdati opened this issue Sep 19, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@SaadArdati
Copy link

SaadArdati commented Sep 19, 2019

  • Animation duration when closing the refresh widget should be adjustable (and faster by default)
  • Refreshing should be cancelled if you pulled the screen down, then pulled it back up manually (and shouldn't flatten horizontally)
  • Option to replace the spinning widget with CircularProgressIndicator(value: )
@AadumKhor AadumKhor added the enhancement New feature or request label Apr 30, 2020
@AadumKhor
Copy link
Collaborator

@SwissCheese5 solved first part of this issue in the last merge. Will continue working on it. Changes will be reflected in latest package update. Thank you for your suggestions.

@AadumKhor
Copy link
Collaborator

@SwissCheese5 we thought about it and did some experiments with the changes you suggested. While working on them we realized that the last two suggestions are not in the scope of the package. I'll explain why.

The second suggestion would make our functionality counter-intuitive since after the refresh initiates, our app should wait for that to finish, it should not be interrupted. On top of this, Flutter's built in RefreshIndicator does not support cancelling the refresh once it has begun on screen. With that as a standard we decided not to move forward with this.

We experimented with the possibility of having the built in CircularProgressIndicator instead of our custom built indicator. It simply does not match the essence of the package and looks out of place.

Since the only suggestion this issue had has been resolved in recent commits, I think we should close this now. Feel free to add something to this and reopen the issue if you think it is necessary. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants