Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Percentage parameter for TextLiquidFill widget #75

Closed
CesarPrz opened this issue May 20, 2020 · 3 comments · Fixed by #166
Closed

Feature request: Percentage parameter for TextLiquidFill widget #75

CesarPrz opened this issue May 20, 2020 · 3 comments · Fixed by #166
Labels
enhancement New feature or request

Comments

@CesarPrz
Copy link

Is your feature request related to a problem? Please describe.
I wanted to fill up the waves with a parameter for the TextLiquidFill widget, which is not possible.

Describe the solution you'd like
Add a percentage parameter on the TextLiquidFill
(After looking at your source code, i think it would be as simple as to replace
text_liquid_fill.dart:130 percentValue: _loadValue.value,
to
text_liquid_fill.dart:130 percentValue: _percentage ? percentage : _loadValue.value,

Thank you for your work on this package !
@aagarwal1012 aagarwal1012 added the enhancement New feature or request label Nov 5, 2020
@aagarwal1012
Copy link
Owner

@CesarPrz, can you make a PR for this change?

@CesarPrz
Copy link
Author

CesarPrz commented Nov 5, 2020

Sure thing, i'm busy right now but i'll do it this weekend.

@aagarwal1012
Copy link
Owner

@CesarPrz, thanks for the quick response.

@awhitford awhitford mentioned this issue Dec 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@CesarPrz @aagarwal1012