Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlignmentGeometry is unused #153

Closed
awhitford opened this issue Nov 26, 2020 · 3 comments
Closed

AlignmentGeometry is unused #153

awhitford opened this issue Nov 26, 2020 · 3 comments
Labels
redundancy Redundant feature/code

Comments

@awhitford
Copy link
Collaborator

awhitford commented Nov 26, 2020

I noticed that many classes have a property like this:

/// Adds [AlignmentGeometry] property to the text in the widget.
///
/// By default it is set to [AlignmentDirectional.topStart]
final AlignmentGeometry alignment;

However, it is not used.

As a result, I recommend removing it to avoid confusion.

This impacts:

  • Colorize
  • Fade
  • Scale
  • Typer
  • Typerwriter
@awhitford
Copy link
Collaborator Author

@aagarwal1012 Can we get away with removing this all at once? Or should we leave a @deprecated parameter for a release to warn people? (Since it was not used, I'm leaning towards just removing it altogether.)

@aagarwal1012
Copy link
Owner

@awhitford, let's remove this unused parameter and create a new release.

@awhitford
Copy link
Collaborator Author

This parameter is used only by RotateAnimatedTextKit. I'll submit a PR in a second.

@aagarwal1012 aagarwal1012 added the redundancy Redundant feature/code label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redundancy Redundant feature/code
Projects
None yet
Development

No branches or pull requests

2 participants