Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect getDependencies() #9

Closed
buckle2000 opened this issue Feb 3, 2018 · 7 comments
Closed

Incorrect getDependencies() #9

buckle2000 opened this issue Feb 3, 2018 · 7 comments

Comments

@buckle2000
Copy link

buckle2000 commented Feb 3, 2018

http://brunch.io/docs/plugins#method-getdependencies-file-array-path-

Method: getDependencies(file): Array[Path]
Given a file, this should return a list of file paths that depend on this one.

However, the current getDependencies returns "a list of file paths that this one depends on", not "a list of file paths that depend on this one".

@buckle2000
Copy link
Author

Or is the description of getDependencies incorrect? For some reasons, this dependency system is still not working.

@buckle2000
Copy link
Author

buckle2000 commented Feb 3, 2018

brunch never calls getDependencies(any_template). It never asks for that information, so there is no way it can update dependents on update (in watch mode). It may be a design flaw of brunch.

@buckle2000
Copy link
Author

So I fixed getDependenies, but the dependency system is still broken. 😕 😞

@aMarCruz
Copy link
Owner

aMarCruz commented Feb 7, 2018

@buckle2000 thanks for the feedback, I will investigate this.

@buckle2000
Copy link
Author

buckle2000 commented Feb 7, 2018

There is something wrong with brunch itself. brunch/brunch#1789

@aMarCruz
Copy link
Owner

aMarCruz commented Feb 8, 2018

yeah, recompiling dependencies with brunch is a nightmare :)

@aMarCruz
Copy link
Owner

@buckle2000 , pugjs-brunch v2.11.0 is in npm, I hope this version solves issues with the watcher.

Seems Brunch is unmaintained now and I don't know if I will update this plugin anymore.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants