Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Block #15

Open
dhanson-wp opened this issue Jul 19, 2024 · 3 comments · May be fixed by #12
Open

Tabs Block #15

dhanson-wp opened this issue Jul 19, 2024 · 3 comments · May be fixed by #12
Assignees

Comments

@dhanson-wp
Copy link

dhanson-wp commented Jul 19, 2024

See WordPress/gutenberg#34079.

A block that allows users to organize content into tabs. I’m not sure about all the UX yet (the relationship between the actual tab element and its content is tricky to get right in the editor), but it could be a good starting point.

tabs

@dhanson-wp dhanson-wp converted this from a draft issue Jul 19, 2024
@dhanson-wp dhanson-wp linked a pull request Jul 19, 2024 that will close this issue
@gziolo gziolo linked a pull request Jul 22, 2024 that will close this issue
@gziolo
Copy link
Collaborator

gziolo commented Jul 24, 2024

I wrapped up the week-long exploration of the Tabs block. I shared where I left in #12 (comment). I recreated the Example of Tabs with Automatic Activation from ARIA Authoring Practices Guide (APG). This is how it looks in action:

Progress.July.19th.mov

I discussed some of the design choices more in-depth with @jarekmorawski in the issue created in the Gutenberg repository:

@creativecoder is experimenting now with how the Tabs block could get implemented in the Gutenberg plugin:

@ahmad-aziz-web
Copy link

@gziolo I have came across your tabs block, the issue arises when we use multiple tabs blocks in same page then switching between tabs items of second tabs block changes the panel of the first tabs block.

@gziolo
Copy link
Collaborator

gziolo commented Aug 26, 2024

@gziolo I have came across your tabs block, the issue arises when we use multiple tabs blocks in same page then switching between tabs items of second tabs block changes the panel of the first tabs block.

Yes, that's a known issue, as I didn't finish the implementation. The IDs generated for the tab elements aren't unique between different instances on the same page. The work continues in the Gutenberg repository:

I quickly skimmed the code, and it might suffer from the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Build 🏗
Development

Successfully merging a pull request may close this issue.

3 participants