Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional markup inside the node with as-sortable can cause quirks #388

Open
benjaminapetersen opened this issue Aug 23, 2017 · 0 comments

Comments

@benjaminapetersen
Copy link

This may not need to be fixed, but rather documented. Essentially I had this:

<div as-sortable>
  <div> header stuff </div>
  <div as-sortable-item>foo</div>
  <div as-sortable-item>bar</div>
  <div as-sortable-item>baz</div>
</div>

The first div caused a number of quirks, but unexpected ones. For example, the second to last sortable item could be dragged, but not into last place. However, items before the second to last could be dragged. Also, you could drag the last up into previous positions.

I'd tend to think it could easily be documented as-sortable-items should be the only children of as-sortable. I'm only opening it as an issue as it was tricky to track down (my actual markup was much more complex).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant