Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmdline datasource overflow #198

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

ken3
Copy link
Contributor

@ken3 ken3 commented Apr 20, 2021

Checklists for Pull requests

About pull request itself:

  • I am submitting a pull request! :)
  • [X ] My submission does one logical thing only (one bugfix, one new feature). If I will want to supply multiple logical changes, I will submit multiple pull requests.
  • [X ] I have read and understood the CONTRIBUTING guide

Code quality:
(not applicable for non-code fixes)

  • My submission is passing the test suite run (./configure --enable-everything && make tests) - test suite reports zero unexpected failures.

Commits:

  • [X ] My commits are logical, easily readable, and with concise comments.
  • [X ] My commits follow the KISS principle: do one thing, and do it well.

Licensing:

  • [X ] I am the author of this submission or I have been authorized by the submission copyright holder to issue this pull request. By issuing this pull request the copyright holder agrees that their contribution is included in Snoopy and released under the current Snoopy license (currently GPLv2).

Branching:

  • [X ] My submission is based on master branch.
  • [X ] My submission is compatible with the latest master branch (no conflicts, I did a rebase if it was necessary).
  • [X ] The name of the branch I want to merge upstream is not master.
  • My branch name is feature/my-shiny-new-snoopy-feature-title (for new features).
  • [X ] My branch name is bugfix/my-totally-non-hackish-workaround (for bugfixes).
  • My branch name is doc/what-i-did-to-documentation (for documentation updates).

Continuous integration:

  • [X ] Once I submit this pull request, I will wait for a CI report (normally done in a few minutes) and fix any issues CI points out.

Pull request description

Shell command with very long args (cmdLineSizeRet > 2048bytes) sometimes gets SIGSEGV. Valgrind reports memory corruption in snoopy_datasource_cmdline() and I have just fixed it.

@bostjan
Copy link
Member

bostjan commented Apr 20, 2021

OMG such an obvious one, thanks @ken3!

@bostjan bostjan merged commit 532673d into a2o:master Apr 20, 2021
@bostjan bostjan added this to the 2.4.14 milestone Apr 20, 2021
@bostjan
Copy link
Member

bostjan commented Apr 20, 2021

The fix is available in the 2.4.14 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants