-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL branch: Naming the executable #22
Comments
Hi. Looks like you forgot to add SDL.h About name of bin: My opinion is curseofwar-sdl. Because:
|
Do you know, is it ok to install manpage "curseofwar.6.gz" etc, but "curseofwar-x" executable? |
AFAIK, no. Each bin must have a manpage. We can set $(EXEC) in Makefile in dependency on ncurses/sql. By this way, we can save rest of all install steps untouched. But, we have to have special manpage for surceofwar-sdl OR do one more sed to set by sed %EXEC%. Last is better. WDYT? |
I have ho idea ) Maybe you are right, it sounds ok to me. Does Debian has any instructions for this kind of problem? |
Yeap, I think do one more sed is good idea until manpages will be different. AFAIK, Debian doen't have spesial instructions on that, but i'm sure there is "best practics" :) And I'll know it when I'll try to publish a multi package. |
Ok. Yeah, don't do pull requests for now. There will be other changes in the makefile, and in the source code. For example, images must be installed correctly, so pull requests will only complicate things. I will also look at other game projects to see what their developers do. |
Hey guys, I ended up with the following installation principle:
My implementation is rather sloppy at the moment: To build a game for running it in the same directory without installation: To build for installation:
To install this executable and other files
To uninstall:
It's possible to build, install and uninstall both versions, doing something like this:
I don't like my implementation myself, but it kinda does the job, at least it demonstrates the idea, how everything can be installed. |
There is a major flaw in the current version. If you make and install to a temporary DESTDIR, wich is a common practice when making a package from sources (say with Arch AUR, and probably everywhere else), the executable will be searching for images there. Even if the package is later installed to /, for exmaple. I don't know what I was thinkng about. It's relly stupid, sorry. |
We all are learning on our own mistakes ) It's ok and somethins funny if not fatal :D We can see here why developing and testing in branch in good :) |
Request our testing when it will be needed. |
New attempt:
If So, something like this should work, for example:
By Linux standards |
Alexey, What about "If you make and install to a temporary DESTDIR, wich is a common practice when making a package from sources" |
I think, it's better to make DATADIR optional, and rely primarily on standard paths, such as It simplifies installation, and its convenient: any user can simply copy all new data in one of those directories, and it will work. Then, DATADIR variable becomes really optional, and only needed if you wish to install data with make, or if you want to keep this data in a non-standard place. It will promote player's involvement for making their own tilesets, maps, etc. |
Agree with your last meassage. |
Anton you will do this:
Yeah, copy by hand. Do you see what I mean? |
I agree though that these manipulations with DATADIR and DESTDIR are still ugly.. We should go for search in standard directories.. I will implement this sarch first. Maybe tomorrow, or on Saturday. |
Yes, I understand. We can do something like that in the package. |
Yep, I think I think, there will be a function like There must be some compatibility layer for Windows in this |
|
(1) Well, the point for searching every time is to have some data in Because we don't load a lot of files, and it is done only when starting the game, it should not take much computational resources, but will be rather convenient. (3) exactly, you can, but don't have to. (4) yes. |
To build the graphical version:
(i.e. the variable SDL must be defined)
To run:
Don't try to install. It does not work correctly.
I have the following problem: Do we need to call the SDL executable "curseofwar-sdl" or "curseofwar"?
On one hand, I would like to name two executables differently, so you will be able to make and install both. On the other hand, what should we do with the manpage, changelog, and probably other things that are called "curseofwar" already? Do we install them as is for both versions? Do you have any experience with issues like this. It looks like the Doungeon Crawl Stone Soup Makefile builds executable "crawl", no matter what version you want to build.
The text was updated successfully, but these errors were encountered: