Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: Multi-line Go control blocks are not correctly syntax highlighted #524

Closed
alehechka opened this issue Feb 14, 2024 · 4 comments
Closed
Labels
bug Something isn't working NeedsFix Needs implementing vscode

Comments

@alehechka
Copy link
Contributor

alehechka commented Feb 14, 2024

Overview

This is more of a follow-up to #508 which was partially resolved for inline import expressions. That issue was automatically closed when the PR to resolve inline was merged. This will track work for resolving the multi-line parameter import expressions.

@alehechka
Copy link
Contributor Author

alehechka commented Feb 14, 2024

Opened a PR to resolve import expressions: templ-go/templ-vscode#30.

@leandergangso fyi

@joerdav joerdav added bug Something isn't working vscode NeedsFix Needs implementing labels Feb 15, 2024
@alehechka alehechka changed the title vscode: Multi-line parameter import expressions do not have syntax highlighting vscode: Multi-line Go syntax control blocks are not correctly syntax highlighted Feb 16, 2024
@alehechka alehechka changed the title vscode: Multi-line Go syntax control blocks are not correctly syntax highlighted vscode: Multi-line Go control blocks are not correctly syntax highlighted Feb 16, 2024
@alehechka
Copy link
Contributor Author

I also noticed that other multi-line blocks are not correctly syntax highlighted, one being if/else-if blocks.

Inline if/else-if

before-working-statements

Multi-line broke if/else-if syntax

before-broken-statements

@alehechka
Copy link
Contributor Author

Also opened templ-go/templ-vscode#31 to resolve the broken multi-line if/else-if statement syntax highlighting.

@alehechka
Copy link
Contributor Author

Both mentioned PRs have been merged, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NeedsFix Needs implementing vscode
Projects
None yet
Development

No branches or pull requests

2 participants