Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code plugin: changelog tab #101

Closed
PaluMacil opened this issue Jun 17, 2023 · 2 comments
Closed

VS Code plugin: changelog tab #101

PaluMacil opened this issue Jun 17, 2023 · 2 comments

Comments

@PaluMacil
Copy link

Currently https://github.com/a-h/templ-vscode/blob/main/CHANGELOG.md is just the initial template. It would be great to have details because while I'm trying to be an early adopter of templ, a friend I collaborate with frequently feels that the language server and/or IDE plugin is just not anywhere close to being truly helpful at this point. Separately, I would love to see a Goland plugin, but in the near term, I think seeing more detail on the changelog will let people see if there is interesting progress to take a look at. Currently I am using Goland with no assistance at all, but looking at the state today reveals to me that a lot of progress was made since I last used this plugin a few weeks ago.

@PaluMacil PaluMacil changed the title VS Code plugin: VS Code plugin: changelog tab Jun 18, 2023
@a-h
Copy link
Owner

a-h commented Jun 19, 2023

Thanks, most of the work is actually in the LSP (https://github.com/a-h/templ/tree/main/cmd/templ/lspcmd). I've done a lot of work on the internals - I rebuilt the parser to take advantage of Go generics and reduce the code volume, and rewrote the internal document representation (the previous version was a source of many bugs). There's also a really useful internal viewer in the LSP now - it can start a web server you can use to visualise its internal state which made it much easier to track down weirdness.

I'm thinking of adding some realtime logging visualisation in there too, because reading the JSON logs is quite tricky.

The VS Code plugin basically just passes commands and data to/from the LSP program and includes a syntax highlighting file. There's no interesting code in it at all.

I expected the changelog of the VS Code plugin to be updated automatically by the VS Code tooling using the git commit history, I didn't spot that it wasn't updated. I expect there's a tool that does this, and the job is just to add it to the npm scripts.

wrt to a Goland plugin, I expect that Goland is similar to VS Code, in that it's a case of providing an appropriate syntax highlighting file, and a way of configuring / starting the LSP.

My current focus is around the LSP, when I'm really happy with that, then I could take a look at the Goland side.

@a-h
Copy link
Owner

a-h commented Aug 20, 2023

OK, I've updated the project to use standard-version to automate the creation of CHANGELOG.md in templ-go/templ-vscode@6b01a22#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

This is now reflected in the VS Code Extension page: https://marketplace.visualstudio.com/items/a-h.templ/changelog

I've created #127 to track the Goland IDE support - they released LSP support recently, so it looks pretty straightforward to implement. I think the syntax highlighting uses the same format at VS Code too.

Probably best to carry that conversation on over there. 😁

@a-h a-h closed this as completed Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants