-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide API access to usernames #97
Comments
Something like this?
|
That works |
PR open in #99, on the Rails 7 branch, to be merged and deployed soon(tm). |
I'd rather not have Tab-internal ID's in there (if it's not needed to create a transaction), this can only cause confusion. |
Good point. I'm still on the fence about using usernames to create transactions, but I guess it makes sense here as our usernames are uniquely defined. I'll leave them out! |
It would be nice to have Zeus ID's here (and to apply this to other apps in the future as well) and also use those ID's as the primary way of authentication. |
I agree, but I think this is a bit out of scope for this issue. If/When we implement this, we'll probably need more changes than just the API (e.g. we might discard internal Tab ID's all together and just use the global Zeus ID as the primary key in Tab/Tap/...) |
This got merged by accident 😬 See #99 |
This would allow autocomplete when creating a transactions.
This data is already available in the HTML, so this shouldn't have any privacy implications.
The text was updated successfully, but these errors were encountered: