Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API access to usernames #97

Closed
niknetniko opened this issue May 26, 2022 · 8 comments
Closed

Provide API access to usernames #97

niknetniko opened this issue May 26, 2022 · 8 comments
Assignees

Comments

@niknetniko
Copy link
Member

niknetniko commented May 26, 2022

This would allow autocomplete when creating a transactions.
This data is already available in the HTML, so this shouldn't have any privacy implications.

@TomNaessens
Copy link
Member

Something like this?

GET http://localhost:3000/api/v1/users

[
	{
		"id": 1,
		"name": "Zeus"
	},
	{
		"id": 2,
		"name": "silox"
	},
	{
		"id": 3,
		"name": "j"
	},
	{
		"id": 4,
		"name": "admin"
	},
	{
		"id": 5,
		"name": "blarghblargh"
	},
	{
		"id": 6,
		"name": "blarghblarghblargh"
	},
	{
		"id": 7,
		"name": "testtest"
	}
]

@niknetniko
Copy link
Member Author

That works

@TomNaessens
Copy link
Member

PR open in #99, on the Rails 7 branch, to be merged and deployed soon(tm).

@TomNaessens TomNaessens self-assigned this May 29, 2022
@redfast00
Copy link
Member

I'd rather not have Tab-internal ID's in there (if it's not needed to create a transaction), this can only cause confusion.

@TomNaessens
Copy link
Member

Good point. I'm still on the fence about using usernames to create transactions, but I guess it makes sense here as our usernames are uniquely defined. I'll leave them out!

@rien
Copy link
Contributor

rien commented May 30, 2022

It would be nice to have Zeus ID's here (and to apply this to other apps in the future as well) and also use those ID's as the primary way of authentication.

@niknetniko
Copy link
Member Author

It would be nice to have Zeus ID's here (and to apply this to other apps in the future as well) and also use those ID's as the primary way of authentication.

I agree, but I think this is a bit out of scope for this issue. If/When we implement this, we'll probably need more changes than just the API (e.g. we might discard internal Tab ID's all together and just use the global Zeus ID as the primary key in Tab/Tap/...)

@TomNaessens TomNaessens added the API label Jun 5, 2022
@TomNaessens
Copy link
Member

This got merged by accident 😬

See #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants