Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/104/103/add reset confirmation and copy button #115

Merged
merged 2 commits into from
Jun 4, 2022
Merged

Feature/104/103/add reset confirmation and copy button #115

merged 2 commits into from
Jun 4, 2022

Conversation

TomNaessens
Copy link
Member

Fixes #104
Fixes #103

@TomNaessens TomNaessens requested review from mcbloch and chvp June 4, 2022 11:00
@chvp
Copy link
Member

chvp commented Jun 4, 2022 •
edited
Loading

Testing locally, there is no confirmation when pressing the reset button (and there are no errors in the console or other signifiers that something went wrong). (Nvm, I'm an idiot.) Also, it might be nice to add some visual confirmation to the copy to clipboard press (like a simple "Copied!" pop-up).

@TomNaessens
Copy link
Member Author

Good idea, created a ticket in #117 for the visual confirmation

@TomNaessens TomNaessens merged commit 733eafc into master Jun 4, 2022
@TomNaessens TomNaessens deleted the feature/104/103/add-reset-confirmation-and-copy-button branch June 4, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@mcbloch mcbloch Awaiting requested review from mcbloch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add copy to clipboard to API key Add confirmation to reset key
2 participants
@TomNaessens @chvp