arch: Added cpu idle fnctions for dspic (zephyrproject-rtos#34)

Adhil-Ign · web-flow · commit ced6afe284ed · 2025-08-05T22:25:59.000+05:30
Added implementations for arch_cpu_idle and arch_cpu_atomic_idle functions

Signed-off-by: Adhil Xavier &lt;adhil.xavier@ignitarium.com&gt;
diff --git a/arch/Kconfig b/arch/Kconfig
@@ -181,8 +181,6 @@ config DSPIC
 	select ATOMIC_OPERATIONS_C
 	select ARCH_HAS_VECTOR_TABLE_RELOCATION
 	select CPU_HAS_ICACHE
-	select ARCH_HAS_CUSTOM_CPU_IDLE
-	select ARCH_HAS_CUSTOM_CPU_ATOMIC_IDLE
 	select CACHE_MANAGEMENT
 	select TICKLESS_CAPABLE
 	help
diff --git a/arch/dspic/core/cpu_idle.c b/arch/dspic/core/cpu_idle.c
@@ -6,17 +6,24 @@
 #include <zephyr/irq.h>
 #include <zephyr/tracing/tracing.h>
 #include <zephyr/arch/cpu.h>
+#include <xc.h>
 
 #ifndef CONFIG_ARCH_HAS_CUSTOM_CPU_IDLE
 void arch_cpu_idle(void)
 {
+	__builtin_disable_interrupts();
+	Idle();
+	__builtin_enable_interrupts();
 }
 #endif
 
 #ifndef CONFIG_ARCH_HAS_CUSTOM_CPU_ATOMIC_IDLE
 void arch_cpu_atomic_idle(unsigned int key)
 {
-	(void)key;
+	__builtin_disable_interrupts();
+	Idle();
+	arch_irq_unlock(key);
+	__builtin_enable_interrupts();
 }
 #endif
 
diff --git a/include/zephyr/kernel.h b/include/zephyr/kernel.h
@@ -6347,9 +6347,7 @@ __syscall int k_poll_signal_raise(struct k_poll_signal *sig, int result);
  */
 static inline void k_cpu_idle(void)
 {
-#ifdef TO_BE_IMPLEMENTED_LATER
 	arch_cpu_idle();
-#endif
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -6,17 +6,24 @@`
`6`	`6`	`#include <zephyr/irq.h>`
`7`	`7`	`#include <zephyr/tracing/tracing.h>`
`8`	`8`	`#include <zephyr/arch/cpu.h>`
	`9`	`+#include <xc.h>`
`9`	`10`
`10`	`11`	`#ifndef CONFIG_ARCH_HAS_CUSTOM_CPU_IDLE`
`11`	`12`	`void arch_cpu_idle(void)`
`12`	`13`	`{`
	`14`	`+ __builtin_disable_interrupts();`
	`15`	`+ Idle();`
	`16`	`+ __builtin_enable_interrupts();`
`13`	`17`	`}`
`14`	`18`	`#endif`
`15`	`19`
`16`	`20`	`#ifndef CONFIG_ARCH_HAS_CUSTOM_CPU_ATOMIC_IDLE`
`17`	`21`	`void arch_cpu_atomic_idle(unsigned int key)`
`18`	`22`	`{`
`19`		`- (void)key;`
	`23`	`+ __builtin_disable_interrupts();`
	`24`	`+ Idle();`
	`25`	`+ arch_irq_unlock(key);`
	`26`	`+ __builtin_enable_interrupts();`
`20`	`27`	`}`
`21`	`28`	`#endif`
`22`	`29`
Original file line number	Diff line number	Diff line change
`@@ -6347,9 +6347,7 @@ __syscall int k_poll_signal_raise(struct k_poll_signal *sig, int result);`
`6347`	`6347`	`*/`
`6348`	`6348`	`static inline void k_cpu_idle(void)`
`6349`	`6349`	`{`
`6350`		`-#ifdef TO_BE_IMPLEMENTED_LATER`
`6351`	`6350`	`arch_cpu_idle();`
`6352`		`-#endif`
`6353`	`6351`	`}`
`6354`	`6352`
`6355`	`6353`	`/**`