fix: Action fails when previous commit had a failing test

Author: thelukewalton

dist/index.js

@@ -113661,6 +113661,7 @@ const getCoverage = (prevCoverage, coverageDirectory) => {
         console.error("Error checking coverage", error);
         response = { output: exports.COV_FAILURE, error: true };
     }
+    (0, node_fs_1.unlinkSync)(`${coverageDirectory}/lcov.info`);
     (0, core_2.debug)("Finished checking coverage; generated response");
     (0, core_1.endGroup)();
     return response;
@@ -113687,6 +113688,7 @@ const artifact_1 = __nccwpck_require__(26984);
 const core_1 = __nccwpck_require__(72614);
 const core_2 = __nccwpck_require__(72614);
 const adm_zip_1 = __importDefault(__nccwpck_require__(98154));
+const runTests_1 = __nccwpck_require__(99054);
 const ARTIFACT_NAME = "coverage";
 /**
  * Retrieve previous coverage report from the base branch
@@ -113768,13 +113770,21 @@ exports.retrievePreviousCoverage = retrievePreviousCoverage;
 const generatePreviousCoverage = async (prev_sha, current_branch, coverage_directory) => {
     const artifact = new artifact_1.DefaultArtifactClient();
     await (0, exec_1.exec)(`git checkout ${prev_sha}`);
-    await (0, exec_1.exec)(`flutter test --coverage --coverage-path ${coverage_directory}/lcov.info`);
-    const report = await (0, utils_1.importLcov)(coverage_directory);
-    const { id, size } = await artifact.uploadArtifact(ARTIFACT_NAME + "-" + prev_sha, [`${coverage_directory}/${utils_1.COV_FILE}`], ".", {});
-    (0, core_2.debug)(`Artifact uploaded with id: ${id} and size: ${size}`);
-    await (0, exec_1.exec)(`git reset --hard`);
-    await (0, exec_1.exec)(`git checkout ${current_branch}`);
-    return report;
+    let report;
+    try {
+        await (0, runTests_1.getTest)(coverage_directory);
+        report = await (0, utils_1.importLcov)(coverage_directory);
+        const { id, size } = await artifact.uploadArtifact(ARTIFACT_NAME + "-" + prev_sha, [`${coverage_directory}/${utils_1.COV_FILE}`], ".", {});
+        (0, core_2.debug)(`Artifact uploaded with id: ${id} and size: ${size}`);
+    }
+    catch (e) {
+        console.error("Failed to run tests");
+    }
+    finally {
+        await (0, exec_1.exec)(`git reset --hard`);
+        await (0, exec_1.exec)(`git checkout ${current_branch}`);
+        return report;
+    }
 };
 
 

src/scripts/coverage.ts

@@ -1,5 +1,5 @@
 import { Lcov, LcovDigest, parse, sum } from "lcov-utils";
-import { readFileSync } from "node:fs";
+import { readFileSync, unlinkSync } from "node:fs";
 import { endGroup, startGroup } from "@actions/core";
 import { stepResponse } from "../main";
 import { debug } from "@actions/core";
@@ -62,6 +62,7 @@ export const getCoverage = (prevCoverage: Lcov | undefined, coverageDirectory: s
     console.error("Error checking coverage", error);
     response = { output: COV_FAILURE, error: true };
   }
+  unlinkSync(`${coverageDirectory}/lcov.info`);
   debug("Finished checking coverage; generated response");
   endGroup();
   return response;

src/scripts/prevCoverage.ts

@@ -7,6 +7,7 @@ import { DefaultArtifactClient } from "@actions/artifact";
 import { endGroup, startGroup } from "@actions/core";
 import { debug } from "@actions/core";
 import AdmZip from "adm-zip";
+import { getTest } from "./runTests";
 
 const ARTIFACT_NAME = "coverage";
 
@@ -104,20 +105,27 @@ const generatePreviousCoverage = async (
   prev_sha: string,
   current_branch: string,
   coverage_directory: string
-): Promise<Lcov> => {
+): Promise<Lcov | undefined> => {
   const artifact = new DefaultArtifactClient();
   await exec(`git checkout ${prev_sha}`);
-  await exec(`flutter test --coverage --coverage-path ${coverage_directory}/lcov.info`);
-  const report = await importLcov(coverage_directory);
-  const { id, size } = await artifact.uploadArtifact(
-    ARTIFACT_NAME + "-" + prev_sha,
-    [`${coverage_directory}/${COV_FILE}`],
-    ".",
-    {}
-  );
+  let report: Lcov | undefined;
+  try {
+    await getTest(coverage_directory);
+    report = await importLcov(coverage_directory);
 
-  debug(`Artifact uploaded with id: ${id} and size: ${size}`);
-  await exec(`git reset --hard`);
-  await exec(`git checkout ${current_branch}`);
-  return report;
+    const { id, size } = await artifact.uploadArtifact(
+      ARTIFACT_NAME + "-" + prev_sha,
+      [`${coverage_directory}/${COV_FILE}`],
+      ".",
+      {}
+    );
+
+    debug(`Artifact uploaded with id: ${id} and size: ${size}`);
+  } catch (e) {
+    console.error("Failed to run tests");
+  } finally {
+    await exec(`git reset --hard`);
+    await exec(`git checkout ${current_branch}`);
+    return report;
+  }
 };