Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor production code that matches on Testnet to use a new Network method for each consensus rule #8326

Closed
Tracked by #7845
arya2 opened this issue Feb 26, 2024 · 0 comments · Fixed by #8340
Closed
Tracked by #7845

Refactor production code that matches on Testnet to use a new Network method for each consensus rule #8326

arya2 opened this issue Feb 26, 2024 · 0 comments · Fixed by #8340
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-testing Category: These are tests good first issue

Comments

@arya2
Copy link
Contributor

arya2 commented Feb 26, 2024 •
edited
Loading

Motivation

We want to move this logic to methods and add unit tests for the methods so it's easier to review the following PRs that add Testnet parameters.

See step 2 in #7967 (comment)
@arya2 arya2 mentioned this issue Feb 26, 2024
Closed
14 tasks
@arya2 arya2 added A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement NU-6 Network Upgrade: NU6 specific tasks C-testing Category: These are tests good first issue labels Feb 26, 2024
@arya2 arya2 mentioned this issue Feb 26, 2024
Closed
@arya2 arya2 mentioned this issue Feb 28, 2024
Merged
9 tasks
@mpguerra mpguerra added this to the Regtest milestone Mar 6, 2024
@arya2 arya2 mentioned this issue Mar 12, 2024
Merged
8 tasks
@mergify mergify bot closed this as completed in #8340 Mar 12, 2024
@mpguerra mpguerra removed the NU-6 Network Upgrade: NU6 specific tasks label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-testing Category: These are tests good first issue
Projects
Zebra
Archived in project
Milestone
No milestone
2 participants
@mpguerra @arya2