Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable get_mempool_tx results in tests cause CI failures #7598

Closed
teor2345 opened this issue Sep 20, 2023 · 0 comments · Fixed by #7600
Closed

Unstable get_mempool_tx results in tests cause CI failures #7598

teor2345 opened this issue Sep 20, 2023 · 0 comments · Fixed by #7600
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures

Comments

@teor2345
Copy link
Contributor

Motivation

Most of the time the send transactions test passes.

But in the merge queue for PR #7531:

Message: assertion failed: (left == right)
left: 5,
right: 0: developers: should fail if get_mempool_tx start working.
Location: zebrad/tests/common/lightwalletd/send_transaction_test.rs:214

https://github.com/ZcashFoundation/zebra/actions/runs/6241861800/job/16946300444#step:9:572

Originally posted by @arya2 in #7531 (comment)

This is a bug in PR #7349.

Suggested Solution

Disable that assertion entirely, because sometimes it works and sometimes it doesn't.
@teor2345 teor2345 added C-bug Category: This is a bug P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-concurrency Area: Async code, needs extra work to make it work properly. S-needs-triage Status: A bug report needs triage labels Sep 20, 2023
This was referenced Sep 20, 2023
Closed
Merged
@mergify mergify bot closed this as completed in #7600 Sep 21, 2023
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): Remove intermittent asserts in test ZcashFoundation/zebra
2 participants
@mpguerra @teor2345