Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build errors in duckdb #7

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix build errors in duckdb #7

merged 2 commits into from
Jan 22, 2024

Conversation

IgorTodorovskiIBM
Copy link
Contributor

  • Avoid "Platform entropy sources only work on Unix and Windows, see MBEDTLS_NO_PLATFORM_ENTROPY in mbedtls_config.h" error
  • IUTF8 doesn't exist on z/OS

@v1gnesh
Copy link
Collaborator

v1gnesh commented Jan 20, 2024 •
edited
Loading

Thank you, I've also replaced _GIT_ with _STABLE_ and _DEV_.

Links to the PRs where upstream changed -

duckdb/duckdb#9392
duckdb/duckdb#10015

@IgorTodorovskiIBM
Copy link
Contributor Author

Awesome, thank you for updating the PR

v1gnesh
v1gnesh approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@v1gnesh v1gnesh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, upstreams on their way.

This was referenced Jan 22, 2024
Merged
Merged
@v1gnesh v1gnesh merged commit 47b6de8 into main Jan 22, 2024
1 check passed
@v1gnesh v1gnesh deleted the fix_duckdb branch January 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1gnesh v1gnesh v1gnesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorTodorovskiIBM @v1gnesh