Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate s3 error as promise rejection #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abhi7cr
Copy link

@abhi7cr abhi7cr commented Apr 13, 2022

Propagate s3 getObject errors (e.g. invalid byte range) as promise rejections.

Issue link

Tests

Added unit tests. Needed to add 3 chunk test files that serves as responses to S3 getObject calls for happy path test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant