Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about model selection for the evaluation in FMoW-wilds #5

Open
LFhase opened this issue Aug 20, 2022 · 0 comments
Open

Question about model selection for the evaluation in FMoW-wilds #5

LFhase opened this issue Aug 20, 2022 · 0 comments

Comments

@LFhase
Copy link

LFhase commented Aug 20, 2022

Hi Fish authors,

Thanks for the nice work! When I was trying to reproduce the results of Fish in FMoW-wilds, I found the function save_best_model (code) always saves the last epoch model. It seems Fish would use the last epoch model selection instead of selecting the models according to the validation performance, which appears to be different from the wilds evaluation protocol (I also failed to find a corresponding description in the paper).

Maybe I missed something, could you help look into this problem? Thank you very much 😄.

Best, Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant