Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be cool to have authenticated docs access #7

Open
bufferoverflow opened this issue Sep 14, 2016 · 2 comments
Open

Would be cool to have authenticated docs access #7

bufferoverflow opened this issue Sep 14, 2016 · 2 comments

Comments

@bufferoverflow
Copy link

Integrating passport-gitlab2 and using GitLab as Authentication provider would allow to build authenticated docs access.

@YuMS
Copy link
Owner

YuMS commented Sep 14, 2016

Sure, having authenticated docs is cool.

But there are several things that may need a bit more thinking.

  1. passport-gitlab2 gives node server power to use oauth2. But actually, static sites are directly backed by NGINX. NGINX Plus seems to support oauth2 (JWT Authentication) but it's not free.
  2. oauth2_proxy is a powerful proxy but it is a little bit heavy to integrate (too many configurable things to expose). I think it may be better to introduce oauth2_proxy in README as an advanced option to provide GitLab oauth2 and even SSL ( ssl? #6 ) support.
  3. It's hard to say that giving everyone who has access to GitLab the key to a locked doc is sufficient. It may be enough until GCP is able to give freedom to grant a group of people access to some site and another group of people access to some other sites.

@YuMS
Copy link
Owner

YuMS commented Nov 22, 2016

How about just using a fixed user:pass pair to protect the doc and share it with your group? Is this acceptable? Any pitfall?

http://nginx.org/en/docs/http/ngx_http_auth_basic_module.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants