Skip to content

Commit 111d75a

Browse files
aslonnieYoussefEssDS
authored andcommitted
[bazel] rename python runtime to py39 runtime (ray-project#58362)
and move them into bazel dir. getting ready for python version upgrade Signed-off-by: Lonnie Liu <[email protected]>
1 parent f687466 commit 111d75a

File tree

3 files changed

+25
-25
lines changed

3 files changed

+25
-25
lines changed

BUILD.bazel

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,11 @@
99
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
1010
load("@com_github_grpc_grpc//bazel:cython_library.bzl", "pyx_library")
1111
load("@hedron_compile_commands//:refresh_compile_commands.bzl", "refresh_compile_commands")
12-
load("@python3_9//:defs.bzl", python39 = "interpreter")
1312
load("@rules_cc//cc:defs.bzl", "cc_proto_library")
1413
load("@rules_pkg//pkg:mappings.bzl", "pkg_attributes", "pkg_files")
1514
load("@rules_pkg//pkg:zip.bzl", "pkg_zip")
1615
load("@rules_proto//proto:defs.bzl", "proto_library")
17-
load("@rules_python//python:defs.bzl", "py_binary", "py_library", "py_runtime", "py_runtime_pair")
16+
load("@rules_python//python:defs.bzl", "py_binary", "py_library")
1817
load("//bazel:ray.bzl", "COPTS", "PYX_COPTS", "PYX_SRCS", "ray_cc_library")
1918

2019
package(
@@ -23,34 +22,13 @@ package(
2322

2423
# Hermetic python environment, currently only used for CI infra and scripts.
2524

26-
py_runtime(
27-
name = "python3_runtime",
28-
interpreter = python39,
29-
python_version = "PY3",
30-
visibility = ["//visibility:private"],
31-
)
32-
33-
py_runtime_pair(
34-
name = "python_runtime_pair",
35-
py2_runtime = None,
36-
py3_runtime = ":python3_runtime",
37-
visibility = ["//visibility:private"],
38-
)
39-
4025
constraint_setting(name = "hermetic")
4126

4227
constraint_value(
4328
name = "hermetic_python",
4429
constraint_setting = ":hermetic",
4530
)
4631

47-
toolchain(
48-
name = "python_toolchain",
49-
exec_compatible_with = [":hermetic_python"],
50-
toolchain = ":python_runtime_pair",
51-
toolchain_type = "@bazel_tools//tools/python:toolchain_type",
52-
)
53-
5432
platform(
5533
name = "hermetic_python_platform",
5634
constraint_values = [":hermetic_python"],

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ load("@py_deps_buildkite//:requirements.bzl", install_py_deps_buildkite = "insta
8383

8484
install_py_deps_buildkite()
8585

86-
register_toolchains("//:python_toolchain")
86+
register_toolchains("//bazel:py39_toolchain")
8787

8888
register_execution_platforms(
8989
"@local_config_platform//:host",

bazel/BUILD.bazel

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
load("@python3_9//:defs.bzl", python39 = "interpreter")
12
load("@py_deps_buildkite//:requirements.bzl", ci_require = "requirement")
2-
load("@rules_python//python:defs.bzl", "py_binary", "py_library")
3+
load("@rules_python//python:defs.bzl", "py_binary", "py_library", "py_runtime", "py_runtime_pair")
34

45
exports_files([
56
"pytest_wrapper.py",
@@ -60,3 +61,24 @@ config_setting(
6061
"@platforms//cpu:x86_64",
6162
],
6263
)
64+
65+
py_runtime(
66+
name = "py39_runtime",
67+
interpreter = python39,
68+
python_version = "PY3",
69+
visibility = ["//visibility:private"],
70+
)
71+
72+
py_runtime_pair(
73+
name = "py39_runtime_pair",
74+
py2_runtime = None,
75+
py3_runtime = ":py39_runtime",
76+
visibility = ["//visibility:private"],
77+
)
78+
79+
toolchain(
80+
name = "py39_toolchain",
81+
exec_compatible_with = ["//:hermetic_python"],
82+
toolchain = ":py39_runtime_pair",
83+
toolchain_type = "@bazel_tools//tools/python:toolchain_type",
84+
)

0 commit comments

Comments
 (0)