Allow custom optimizers, improve JaxTrainingPlan
#1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adamgayoso
commented
Oct 17, 2022
•
adamgayoso
commented
- Easily add optax/pytorch custom optimizers easily
- Breaking change where we force keyword args to the training plans
Codecov ReportBase: 90.96% // Head: 90.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
- Coverage 90.96% 90.87% -0.09%
==========================================
Files 116 116
Lines 9757 9764 +7
==========================================
- Hits 8875 8873 -2
- Misses 882 891 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adamgayoso
commented
Oct 17, 2022
Comment on lines
+84
to
+88
| # Allclose because on GPU, the values are not exactly the same | ||
| # as latents are moved to cpu in latent mode | ||
| np.testing.assert_allclose( | ||
| params_latent[k], params_orig[k], rtol=3e-1, atol=5e-1 | ||
| ) |
There was a problem hiding this comment.
cc @watiss needed to change this. LMK if the comment makes sense!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.