Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add register_new_fields method to manager #1689

Merged
merged 10 commits into from
Sep 22, 2022
Merged

Add register_new_fields method to manager #1689

merged 10 commits into from
Sep 22, 2022

Conversation

adamgayoso
Copy link
Member

@adamgayoso adamgayoso commented Sep 16, 2022

This allows updating an instance of an AnnDataManager with new fields (assuming it has already been registered with an AnnData object).

We will use this to help put models in latent mode, in which latent dists are cached in anndata and used in forward passes instead of encoding.

@adamgayoso adamgayoso changed the title [WIP] add_fields method to manager [WIP] Add register_new_fields method to manager Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 91.27% // Head: 91.23% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f9eb5b4) compared to base (9ff329e).
Patch coverage: 95.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
- Coverage   91.27%   91.23%   -0.04%     
==========================================
  Files         116      111       -5     
  Lines        9275     9245      -30     
==========================================
- Hits         8466     8435      -31     
- Misses        809      810       +1     
Impacted Files Coverage Δ
scvi/data/_manager.py 98.19% <95.65%> (-0.51%) ⬇️
scvi/__init__.py
scvi/utils/__init__.py
scvi/train/__init__.py
scvi/_utils.py
scvi/_constants.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamgayoso adamgayoso marked this pull request as ready for review September 17, 2022 01:07
@adamgayoso adamgayoso changed the title [WIP] Add register_new_fields method to manager Add register_new_fields method to manager Sep 17, 2022
scvi/data/_manager.py Outdated Show resolved Hide resolved
@adamgayoso adamgayoso added this to the 0.18.0 milestone Sep 22, 2022
@adamgayoso adamgayoso enabled auto-merge (squash) September 22, 2022 21:17
@adamgayoso adamgayoso merged commit 6bd6cb7 into master Sep 22, 2022
@adamgayoso adamgayoso deleted the add_fields branch November 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants