Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dimension mismatch with continuous covariates in generative #1548

Merged
merged 7 commits into from
Jun 21, 2022

Conversation

justjhong
Copy link
Contributor

Fixes #1488

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1548 (b170d42) into master (aabf14d) will increase coverage by 0.06%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   91.08%   91.14%   +0.06%     
==========================================
  Files         113      113              
  Lines        9015     9031      +16     
==========================================
+ Hits         8211     8231      +20     
+ Misses        804      800       -4     
Impacted Files Coverage Δ
scvi/module/_multivae.py 89.83% <40.00%> (-1.50%) ⬇️
scvi/module/_peakvae.py 91.26% <40.00%> (-2.68%) ⬇️
scvi/module/_totalvae.py 88.19% <100.00%> (+0.17%) ⬆️
scvi/module/_vae.py 94.85% <100.00%> (+0.09%) ⬆️
scvi/model/base/_rnamixin.py 92.63% <0.00%> (+1.05%) ⬆️
scvi/model/_totalvi.py 87.59% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabf14d...b170d42. Read the comment docs.

@justjhong justjhong merged commit f7673a6 into master Jun 21, 2022
@justjhong justjhong deleted the jhong/iss1488 branch June 21, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCVI get_normalized_expression() error when including continuous covariates
2 participants