Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when no backup URL provided #1527

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Conversation

justjhong
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1527 (1a8ffd4) into master (096099e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
+ Coverage   90.93%   90.96%   +0.02%     
==========================================
  Files         112      112              
  Lines        8837     8841       +4     
==========================================
+ Hits         8036     8042       +6     
+ Misses        801      799       -2     
Impacted Files Coverage Δ
scvi/data/_download.py 87.17% <100.00%> (+1.46%) ⬆️
scvi/model/base/_utils.py 91.54% <0.00%> (+0.70%) ⬆️
scvi/external/gimvi/_utils.py 76.27% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 096099e...1a8ffd4. Read the comment docs.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you add a release note for the patch and make sure to add it to the rel notes index page?

@adamgayoso adamgayoso enabled auto-merge (squash) April 29, 2022 18:37
@adamgayoso adamgayoso merged commit 91fd3c1 into master Apr 29, 2022
@justjhong justjhong deleted the jhong/backupurlloadfix branch April 29, 2022 18:51
@adamgayoso
Copy link
Member

meeseeksdev backport to 0.16.x

meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request May 10, 2022
adamgayoso pushed a commit that referenced this pull request May 10, 2022
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
* fix msg when no backup url used

* draft release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants