Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards compatibility for TOTALVI #1502

Merged
merged 4 commits into from
Apr 8, 2022
Merged

Conversation

justjhong
Copy link
Contributor

Since TOTALVI.setup_anndata was modified to remove the unnecessary labels key, issues arose when a legacy totalvi model was loaded then saved, then loaded again.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1502 (1588d7a) into master (2660e16) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1502   +/-   ##
=======================================
  Coverage   91.06%   91.07%           
=======================================
  Files         112      112           
  Lines        8809     8813    +4     
=======================================
+ Hits         8022     8026    +4     
  Misses        787      787           
Impacted Files Coverage Δ
scvi/data/_compat.py 90.74% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2660e16...1588d7a. Read the comment docs.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this to the 0.16 release note?

We should talk about removing legacy save load -- I don't think we should get rid of it yet

@justjhong justjhong changed the base branch from 0.15.x to master April 8, 2022 18:50
@adamgayoso adamgayoso enabled auto-merge (squash) April 8, 2022 19:07
@adamgayoso adamgayoso merged commit fb4b4e0 into master Apr 8, 2022
@adamgayoso adamgayoso deleted the jhong/fixtotalvicompat branch May 10, 2022 04:33
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
* run checks

* fix backwards compatibility for totalvi

* fix release note

Co-authored-by: Adam Gayoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants