Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LDA note bugs #1479

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix LDA note bugs #1479

merged 1 commit into from
Mar 31, 2022

Conversation

justjhong
Copy link
Contributor

  • Fix overloaded notation
  • Remove unnecessary backslashes

@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #1479 (2eee8fa) into master (14f5a91) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1479   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files         112      112           
  Lines        8775     8775           
=======================================
  Hits         7989     7989           
  Misses        786      786

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f5a91...2eee8fa. Read the comment docs.

@adamgayoso adamgayoso enabled auto-merge (squash) March 31, 2022 18:22
@adamgayoso adamgayoso merged commit 3091ec3 into master Mar 31, 2022
@adamgayoso adamgayoso deleted the jhong/fixldanote branch March 31, 2022 18:22
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 31, 2022
@justjhong @meeseeksmachine
Backport PR scverse#1479: Fix LDA note bugs
4975f6d
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 31, 2022
Merged
adamgayoso pushed a commit that referenced this pull request Mar 31, 2022
@meeseeksmachine @justjhong
Backport PR #1479: Fix LDA note bugs (#1481)
60f1795 
Co-authored-by: Justin Hong <[email protected]>
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
@justjhong @nrclaudio
fix lda note bugs (scverse#1479)
954ad8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgayoso adamgayoso adamgayoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justjhong @adamgayoso