Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on random kwargs in setup_anndata #1439

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Error on random kwargs in setup_anndata #1439

merged 6 commits into from
Mar 15, 2022

Conversation

justjhong
Copy link
Contributor

Fixes #1429

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1439 (e280cdc) into master (d66c7d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1439   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         111      111           
  Lines        8698     8700    +2     
=======================================
+ Hits         7918     7920    +2     
  Misses        780      780           
Impacted Files Coverage Δ
scvi/external/solo/_model.py 94.77% <ø> (ø)
scvi/data/_manager.py 98.63% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbdeec...e280cdc. Read the comment docs.

@justjhong justjhong merged commit b213388 into master Mar 15, 2022
@justjhong justjhong deleted the jhong/iss1429 branch March 15, 2022 00:42
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 15, 2022
justjhong added a commit that referenced this pull request Mar 15, 2022
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
* error on random kwargs in setup_anndata

* release note

* remove labels for totalvi

* change message to be consistent w python

Co-authored-by: Adam Gayoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arbitrary kwargs can be passed to setup_anndata just before model init
2 participants